fix: allow special use domains by default

[colincasey]

To avoid breaking behavior the allowSpecialUseDomain option should have been set to true by default.

This PR also adds tests that cover when a default CookieStore is created it does allow cookies with special use domains.

closes #246

[halivert]

Thanks @colincasey, great work 🎉

[awaterma]

Looks good to me as well @colincasey; nice to see a fix that makes a change and adds a test. :)

I've also hand-checked straight localhost creation:

cookie@d8759915569c:~$ node 
Welcome to Node.js v16.17.0.
Type ".help" for more information.
> const Cookie = require(".")
undefined
> jar = new Cookie.CookieJar();
CookieJar {
  rejectPublicSuffixes: true,
  enableLooseMode: false,
  allowSpecialUseDomain: true,
  store: { idx: {} },
  prefixSecurity: 'silent',
  _cloneSync: [Function (anonymous)],
  _importCookiesSync: [Function (anonymous)],
  getCookiesSync: [Function (anonymous)],
  getCookieStringSync: [Function (anonymous)],
  getSetCookieStringsSync: [Function (anonymous)],
  removeAllCookiesSync: [Function (anonymous)],
  setCookieSync: [Function (anonymous)],
  serializeSync: [Function (anonymous)]
}
> await(jar.setCookie('settingThisShouldPass=true,Domain=localhost; Path="/;"','http://localhost'))
Cookie="settingThisShouldPass=true,Domain=localhost; Path=/; "; hostOnly=true; aAge=1ms; cAge=1ms"

[awaterma]

Approved

[awaterma]

Merging with single approval and discussion with @colincasey. Will work on our 4.1.1 release next.

[CSchulz]

This doesn't close #246 completly, because there is still the breaking change mentioned in #248 contained.
If you are using localhost as test environment url it is not enough, you have to change it to something else like localhost.local.

[Sourav-techlur]

Hey @awaterma I am still having the same issue with v4.1.1.