Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CookieJar().setCookie crashes when empty cookie is passed #197

Closed
vsin12 opened this issue Jun 18, 2020 · 1 comment · Fixed by #196
Closed

CookieJar().setCookie crashes when empty cookie is passed #197

vsin12 opened this issue Jun 18, 2020 · 1 comment · Fixed by #196

Comments

@vsin12
Copy link
Contributor

vsin12 commented Jun 18, 2020

Some sites while setting cookies, send empty cookies which on parsing gives parsing failed error.
A check for cookie.length or cookie != '' is needed and cb(null) should be returned in such cases.
@vsin12
Copy link
Contributor Author

vsin12 commented Jun 18, 2020

I have made a fix and created a PR #196 for this.

@ShivanKaul ShivanKaul linked a pull request Sep 21, 2020 that will close this issue
Returned null in case of empty cookie value #196
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Returned null in case of empty cookie value vsin12/tough-cookie
1 participant
@vsin12