-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sqlx NamedStmt #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I intend to merge this after #25 is merged.
There is some conflicts. Once those are resolved I will merge. |
I've enabled CI on PRs in |
@ryanrolds Updated! |
Sorry, just noticed I didn't stage my changes 😅 Updated for real this time. Lint/test/build OK in local, I don't think I can trigger the CI myself |
Sorry. I wasn't aware that GH wouldn't run CI automatically on this PR. |
No problem, thanks for the merge! |
Additionally to Stmt and Rows, sqlx exposes NamedStmt
As for Stmt, they should also be closed to avoid pool exhaustion and potential leaks