Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 3.3 bundled gem warning #208

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

m-nakamura145
Copy link
Contributor

Ruby 3.3 has been released. In Ruby 3.3, the nkf gem has become a bundled gem, and it generates the following warning. To avoid this, I have added the nkf gem to the letter_opener.gemspec.

Before

~/work/letter_opener master
❯ ruby -v
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin23]

~/work/letter_opener master
❯ bundle exec rake
/Users/m_nakamura145/work/letter_opener/lib/letter_opener/message.rb:5: warning: kconv is found in nkf, which will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec.

Randomized with seed 23448
....................................................................

Finished in 0.21931 seconds (files took 0.2301 seconds to load)
68 examples, 0 failures

Randomized with seed 23448

After

~/work/letter_opener master*
❯ bundle exec rake

Randomized with seed 31635
....................................................................

Finished in 0.22516 seconds (files took 0.2494 seconds to load)
68 examples, 0 failures

Randomized with seed 31635

@nashby
Copy link
Collaborator

nashby commented Jan 21, 2024

@m-nakamura145 hey, thanks for the PR! Since we use kconv in the gem itself, doesn't it mean we should add nkf to gemspec and not Gemfile?

@m-nakamura145 m-nakamura145 force-pushed the fix-ruby-3.3-bundled-gem-warning branch from fa97a6e to a9d44a0 Compare January 22, 2024 02:00
@m-nakamura145
Copy link
Contributor Author

@nashby Thank you! Fixed! a9d44a0

@nashby nashby merged commit 092ba11 into ryanb:master Jan 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants