-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the readme documentation #108
Conversation
Readme.md
Outdated
|
||
```ruby | ||
if Pry::Prompt[:rails] | ||
Pry.config.prompt = Pry::Prompt[:rails] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this but would recommend providing instructions for pre Pry v0.12.0 as well:
# For Pry v0.12.0+
if Pry::Prompt[:rails]
Pry.prompt = Pry::Prompt["rails"][:value]
end
# For Pry < v0.12.0
if defined?(PryRails::Prompt)
Pry.config.prompt = Pry::Prompt::MAP["rails"][:value]
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure it makes sense to provide documentation for an older API that pry-rails no longer implements.
Readme.md
Outdated
|
||
```ruby | ||
if Pry::Prompt[:rails] | ||
Pry.config.prompt = Pry::Prompt[:rails] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case this got missed in force push:
I like this but would recommend providing instructions for pre Pry v0.12.0 as well:
# For Pry v0.12.0+
if Pry::Prompt[:rails]
Pry.prompt = Pry::Prompt["rails"][:value]
end
# For Pry < v0.12.0
if defined?(PryRails::Prompt)
Pry.config.prompt = Pry::Prompt::MAP["rails"][:value]
end
@pdobb i pushed again. |
Thanks very much! I was making a PR to help, but you were so fast! 👍 |
thanks :) |
Fix for #105 (comment)