Prompt should not infer project_name from the path
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `project_name` implementation infers itself the directory the application exists in. However, this expectation fails several situations, such as - Docker conventionally puts applications in /app - Capistrano conventionally puts applications in /:prefix/project_name/releases/20181126-020459-399a6ff/ Instead, this infers the project name from the `Rails.application` class name, which is set by `rails new`. A similar approach is used in the marco-polo irb prompt gem: https://github.com/arches/marco-polo/blob/0f53f5645bceac45757f061fc9b53ab2396afda7/lib/marco-polo.rb#L17
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
project_nameimplementation infers itself the directory the application exists in. However, this expectation fails several situations, such asInstead, this infers the project name from the
Rails.applicationclass name, which is set byrails new. A similar approach is used in the marco-polo irb prompt gem:https://github.com/arches/marco-polo/blob/0f53f5645bceac45757f061fc9b53ab2396afda7/lib/marco-polo.rb#L17