Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom build.rs path support, local time offset support, updated gix dep #223

Merged
merged 9 commits into from
Jul 1, 2023

Conversation

CraZySacX
Copy link
Member

@CraZySacX CraZySacX commented Jul 1, 2023

  • Updated gix to 0.48.0
  • Added support for specifying a custom build.rs location.
  • Added support for using a local offset for date/timestamp display.
    NOTE - Using a local offset will likely cause failures on Unix systems due to the Soundness check that the time crate performs. I don't want to introduce unsoundness support to vergen.

Fixes #214
Fixes #222

Verified

This commit was signed with the committer’s verified signature.
@CraZySacX CraZySacX added enhancement dependencies Pull requests that update a dependency file labels Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #223 (92615a5) into master (c51c8d3) will decrease coverage by 0.27%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   98.44%   98.17%   -0.27%     
==========================================
  Files          23       23              
  Lines        1609     1645      +36     
==========================================
+ Hits         1584     1615      +31     
- Misses         25       30       +5     
Impacted Files Coverage Δ
vergen/src/feature/git/cmd.rs 97.22% <75.00%> (-0.87%) ⬇️
vergen/src/feature/git/git2.rs 97.47% <75.00%> (+0.59%) ⬆️
vergen/src/feature/git/gix.rs 96.51% <75.00%> (-1.08%) ⬇️
vergen/src/emitter.rs 93.83% <85.71%> (-1.06%) ⬇️
vergen/src/feature/build.rs 100.00% <100.00%> (ø)
vergen/tests/build_output.rs 100.00% <100.00%> (ø)
vergen/tests/git_output.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CraZySacX added 2 commits July 1, 2023 11:30

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@CraZySacX CraZySacX marked this pull request as ready for review July 1, 2023 16:32
CraZySacX and others added 3 commits July 1, 2023 13:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@CraZySacX CraZySacX changed the title added support for specifying custom build.rs path, updated gix dep Custom build.rs path support, local time offset support, updated gix dep Jul 1, 2023
CraZySacX and others added 3 commits July 1, 2023 15:54

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@CraZySacX CraZySacX merged commit 022e804 into master Jul 1, 2023
@CraZySacX CraZySacX deleted the feature/add-custom-buildrs-support branch July 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vergen doesn't respect configured location for build.rs Timezone aware VERGEN_BUILD_TIMESTAMP
2 participants