transition away from deprecated setters internally #4297
Merged
+346
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanderc
force-pushed
the
deprecated-setters
branch
from
d9e9345 to
b7cb2e0
Compare
Changes `ret.foo(foo)` into `ret.set_foo(foo)`
nolanderc
force-pushed
the
deprecated-setters
branch
from
b7cb2e0 to
5361752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old builder style setters are now deprecated, favoring the new
.set_field(...)over the old.field(...). We should make use of the new setters internall.In
wgpu, we vendor the WebGPU bindings from this crate intowgpuitself. This triggers the deprecation warnings, and upgrading to the latestmain, we see about 100 of them strewn throughout the generated bindings. This change aims to remove those warnings.