Add environment variables to configure tests #4295
Merged
+67
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
pushed a commit
to rust-random/getrandom
that referenced
this pull request
Dec 2, 2024
This change runs Wasm tests in workers as well. - Fix Node tests not actually running any tests. It was already broken because of an interaction with the latest Rust version and an old Node.js version. - Test dedicated, shared and service worker by using the newly added environment variables: rustwasm/wasm-bindgen#4295.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the only way to configure the test environment is via the
wasm_bindgen_test_configure!macro (apart from Deno). This can make testing setups quite difficult, requiring many test targets to test various environments.This PR adds environment variables to configure the test environment:
WASM_BINDGEN_USE_BROWSER: for browsersWASM_BINDGEN_USE_DEDICATED_WORKER: for dedicated workersWASM_BINDGEN_USE_SHARED_WORKER: for shared workersWASM_BINDGEN_USE_SERVICE_WORKER: for service workersWASM_BINDGEN_USE_DENO: for DenoWASM_BINDGEN_USE_NODE_EXPERIMENTAL: for Node.js but as an ES moduleHowever,
wasm_bindgen_test_configure!will overwrite any environment variable and force a specific test environment.