Add a test runner to two of the typescript tests to actually run them #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can fix the currently not excluded tests in follow up PRs, but wanted to get the test framework in first before I write a lot of code depending on it. |
hamza1311
reviewed
Nov 18, 2023
|
Good point! They are already running in the CI, as can be seen in the last few lines of I clarified this in the PR description by mentioning the |
hamza1311
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Jest as the test runner framework.
I have chosen this framework because it was the framework I managed to get running and because it seems reasonably popular:
https://2022.stateofjs.com/en-US/libraries/testing/
This uncovers that some of the tests are unrealistic code which would crash at runtime.
Before this PR, these tests were just compiled with tsc, but never run.
This PR also adds the new test script to the
crates/typescript-tests/run.shfile which makes them run in the CI.