Update http crate to 1.0 #407

dgsantana · 2023-11-27T18:52:44Z

This bumps http to 1.0 and also the gloo-net minor version.

tysen

rust-version = "1.67"

in Cargo.toml

ought to resolve these failures.

dgsantana · 2023-11-29T07:55:17Z

I'm not sure this will fix the error. The CI workflow has the tests set for rust 1.64.

hamza1311 · 2023-11-30T09:59:25Z

I would rather inline the one type that's used from http crate than bump the version and MSRV while keeping the requirement of pulling in another dependency. I would be happy to look at any PRs removing the dependency altogether.

This reverts commit 90bb8e6.

This reverts commit 1fa770e.

dgsantana · 2023-11-30T11:53:11Z

Ok, changed the PR title and inlined the http method code, removing the http dependency.

dgsantana · 2023-11-30T12:03:52Z

Note: The failing and the requirement to increase MSRV is not due to http (MSRV is 1.49) but due to "toml_edit v0.19.15", which in turn is not related to the change in gloo-net.
This is due to proc-macro-crate used in gloo-worker-macros.

dgsantana · 2023-11-30T12:11:31Z

I would propose a new PR to fix this, something like this:

diff --git a/crates/worker-macros/Cargo.toml b/crates/worker-macros/Cargo.toml
index 474cd46..d560678 100644
--- a/crates/worker-macros/Cargo.toml
+++ b/crates/worker-macros/Cargo.toml
@@ -19,6 +19,8 @@ proc-macro-crate = "1.2.1"
 proc-macro2 = "1.0.47"
 quote = "1.0.21"
 syn = { version = "2.0.15", features = ["full"] }
+# Required to keep msrv at 1.64
+toml_edit = "=0.19.0"
 
 [dev-dependencies]
 trybuild = "1"

hamza1311 · 2023-11-30T16:37:47Z

The lockfile is present for that. It's most likely that since you updated it before, the lockfile has the previous entry. You can try reverting the change to Cargo.lock and then rebuilding. That should fix the issue

dgsantana · 2023-11-30T17:08:38Z

Done.

hamza1311

There are some things in the http crate that may be unnecessary here. Can you ensure we have only what's needed

crates/net/src/http/method.rs

Reactor to be just the required for gloo-net to work.

dgsantana · 2023-12-01T16:51:24Z

Minimum Method version to work with gloo-net.

hamza1311

Can you also update the CHANGELOG.md accordingly?

crates/net/src/http/method.rs

crates/net/src/http/mod.rs

crates/net/Cargo.toml

tysen · 2023-12-13T00:32:04Z

This mergeable now?

futursolo · 2023-12-13T01:03:33Z

crates/net/src/http/method.rs

+/// HTTP methods that can be used in a fetch request.
+/// The methods as defined by the [fetch spec](https://fetch.spec.whatwg.org/#methods).
+#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
+pub enum Method {


I prefer how the http crate handled it. We should use a struct with associated constants and not enum as you can choose your own http verb.

See: #312 (comment)

I'm not so sure if that's a good idea. Custom HTTP verbs (as far as I know) are not standard. Does fetch even support them?

Just decide what is the better way, I can make the change.

This is supported and documented on MDN.

If you guys want I can use the http crate, I removed as per request by @hamza1311. I made this pull request, because there is interest in updating leptos in the future to use axum 0.7.x, and there are lots of moving parts, including gloo-net.

sabify · 2023-12-18T16:23:03Z

@futursolo's comment is on point and reasonable (#407 (comment)). The http crate is compatible with the current implementation of fetch. By continuing to use the http crate, gloo-net can likely avoid introducing breaking changes that would impact users who are already utilizing the http crate and its custom methods like RequestBuilder::method (https://github.com/rustwasm/gloo/blob/64d81f1b8f919a016a115484efc7963fab2fa4e9/crates/net/src/http/request.rs#L130C8-L130C8).

Perhaps we could move forward using the http crate?

dgsantana · 2023-12-18T16:36:04Z

Ok, I will change the PR to use the http 1.x again, it's simple. Saber Haj Rabiee ***@***.***> escreveu no dia segunda, 18/12/2023 à(s) 16:23:

…

@futursolo <https://github.com/futursolo>'s comment is on point and reasonable (#407 (comment) <#407 (comment)>). The http crate is compatible with the current implementation of fetch. By continuing to use the http crate, gloo-net can likely avoid introducing breaking changes that would impact users who are already utilizing the http crate and its custom methods like RequestBuilder::method ( https://github.com/rustwasm/gloo/blob/64d81f1b8f919a016a115484efc7963fab2fa4e9/crates/net/src/http/request.rs#L130C8-L130C8 ). Perhaps we could move forward using the http crate? — Reply to this email directly, view it on GitHub <#407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAU7OBFZIZDYZX4V4FXTOGDYKBUXHAVCNFSM6AAAAAA74QBS2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQHE2TMMZYGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

tysen · 2023-12-23T21:25:19Z

Maybe update the title of the PR now that http has returned?

hamza1311

Just one change, then this can be merged. Thanks for your work!

CHANGELOG.md

This is a breaking change so it needs a minor version update.

tysen · 2024-01-02T15:12:04Z

This all set now?

CHANGELOG.md

hamza1311

Apologies for the very late review. This looks good. I'll merge it now

torokati44 · 2024-05-02T23:19:43Z

A new release with this (and possibly other, currently open, dependency bump PRs) in it would be greatly appreciated! ^^

chore(deps): bump http to 1.0 on gloo-net

bdfb5b8

tysen suggested changes Nov 28, 2023

View reviewed changes

chore(config): update to rust version 1.67

1fa770e

chore: git workflow updated to rust 1.67

90bb8e6

dgsantana added 3 commits November 30, 2023 11:38

Revert "chore: git workflow updated to rust 1.67"

c5f28a2

This reverts commit 90bb8e6.

Revert "chore(config): update to rust version 1.67"

b95b116

This reverts commit 1fa770e.

feat: Inline http::Method and remove http dependency

bb63166

dgsantana changed the title ~~chore(deps): bump http to 1.0 on gloo-net~~ Inline http crate Method code, removing http dependency Nov 30, 2023

chore: cargo fmt

f1cdaee

chore(docs): fixed doc tests

dfc462c

chore: restore lock file to previous state

764484f

Previous revert missed some of the changes

c5651f7

hamza1311 reviewed Dec 1, 2023

View reviewed changes

crates/net/src/http/method.rs Outdated Show resolved Hide resolved

crates/net/src/http/method.rs Outdated Show resolved Hide resolved

crates/net/src/http/method.rs Outdated Show resolved Hide resolved

Refactor Method.

e0c3813

Reactor to be just the required for gloo-net to work.

chore: Method documentation

f4470d1

hamza1311 reviewed Dec 1, 2023

View reviewed changes

crates/net/src/http/method.rs Outdated Show resolved Hide resolved

crates/net/src/http/mod.rs Outdated Show resolved Hide resolved

crates/net/Cargo.toml Outdated Show resolved Hide resolved

dgsantana added 5 commits December 1, 2023 22:02

Refactor HTTP methods in net crate

fc39493

Reverted gloo-net version to 0.4.0

ebdf6cb

chore: CHANGELOG update

92b605d

chore: typo on CHANGELOG

11816de

fix CHANGELOG for gloo-net

591f607

futursolo reviewed Dec 13, 2023

View reviewed changes

dgsantana added 3 commits December 18, 2023 16:43

Merge remote-tracking branch 'origin/master' into http_version_1_0

aa7dca3

Return to http 1.0 crate.

eb96bad

Updated changelog

1f79537

dgsantana changed the title ~~Inline http crate Method code, removing http dependency~~ Update http crate to 1.0 Dec 23, 2023

hamza1311 reviewed Dec 24, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Moved changelog version from 0.5.0 to 0.6.0

d452c06

This is a breaking change so it needs a minor version update.

futursolo reviewed Jan 9, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

chore: Changed changelog as requested.

3feb95f

hamza1311 approved these changes Jan 11, 2024

View reviewed changes

hamza1311 merged commit a823fab into rustwasm:master Jan 11, 2024
20 checks passed

DaniPopes mentioned this pull request Mar 6, 2024

chore(deps): bump http, hyper etc. to 1.0 paradigmxyz/reth#7018

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update http crate to 1.0 #407

Update http crate to 1.0 #407

dgsantana commented Nov 27, 2023

tysen left a comment

dgsantana commented Nov 29, 2023

hamza1311 commented Nov 30, 2023

dgsantana commented Nov 30, 2023

dgsantana commented Nov 30, 2023

dgsantana commented Nov 30, 2023

hamza1311 commented Nov 30, 2023

dgsantana commented Nov 30, 2023

hamza1311 left a comment

dgsantana commented Dec 1, 2023

hamza1311 left a comment

tysen commented Dec 13, 2023

futursolo Dec 13, 2023

hamza1311 Dec 13, 2023

dgsantana Dec 13, 2023

futursolo Dec 13, 2023 •

edited

dgsantana Dec 13, 2023

sabify commented Dec 18, 2023

dgsantana commented Dec 18, 2023 via email

tysen commented Dec 23, 2023

hamza1311 left a comment

tysen commented Jan 2, 2024

hamza1311 left a comment

torokati44 commented May 2, 2024

Update http crate to 1.0 #407

Update http crate to 1.0 #407

Conversation

dgsantana commented Nov 27, 2023

tysen left a comment

Choose a reason for hiding this comment

dgsantana commented Nov 29, 2023

hamza1311 commented Nov 30, 2023

dgsantana commented Nov 30, 2023

dgsantana commented Nov 30, 2023

dgsantana commented Nov 30, 2023

hamza1311 commented Nov 30, 2023

dgsantana commented Nov 30, 2023

hamza1311 left a comment

Choose a reason for hiding this comment

dgsantana commented Dec 1, 2023

hamza1311 left a comment

Choose a reason for hiding this comment

tysen commented Dec 13, 2023

futursolo Dec 13, 2023

Choose a reason for hiding this comment

hamza1311 Dec 13, 2023

Choose a reason for hiding this comment

dgsantana Dec 13, 2023

Choose a reason for hiding this comment

futursolo Dec 13, 2023 • edited

Choose a reason for hiding this comment

dgsantana Dec 13, 2023

Choose a reason for hiding this comment

sabify commented Dec 18, 2023

dgsantana commented Dec 18, 2023 via email

tysen commented Dec 23, 2023

hamza1311 left a comment

Choose a reason for hiding this comment

tysen commented Jan 2, 2024

hamza1311 left a comment

Choose a reason for hiding this comment

torokati44 commented May 2, 2024

futursolo Dec 13, 2023 •

edited