Gloo net fetch in worker #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza1311
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Can we add test cases for this?
@futursolo do you know if it's possible to run test in gloo-worker?
You can send back the result of tests run within workers when code is run normally within a worker. |
flosse
force-pushed
the
gloo-net-fetch-in-worker
branch
from
9b0f781
to
0ac9a72
Compare
|
@hamza1311 is there something I can do to make this PR merged? |
|
Sorry, took me a while to get to this. It looks good! Thanks for the PR (and the wait) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use
gloo-netin a web extension with manifest V3 but this does not work because of #201.Fortunately @cdata found a workaround 😃
That at least avoids a panic but my service worker of the web extension does not have the
DedicadedWorkerGlobalScopeso I changed it toWorkerGlobalScopebecause as far as I know aDedicadedWorkerGlobalScopeis a specialization ofWorkerGlobalScope.What do you think?