Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record historical, no longer supported target triples in platforms crate #1106

Open
lovesegfault opened this issue Feb 9, 2024 · 4 comments

Comments

@lovesegfault
Copy link

I was trying to use the platform crate to parse the targets present in Rustup channel manifests, such as https://static.rust-lang.org/dist/channel-rust-1.75.0.toml but discovered not all triples are covered by this crate.

Namely, the following target triples were missing from Platform:

  • asmjs-unknown-emscripten
  • x86_64-sun-solaris
@tarcieri
Copy link
Member

tarcieri commented Feb 9, 2024

As it were, those are the two platforms removed in 1.76: https://github.com/rust-lang/rust/releases/tag/1.76.0#compatibility-notes

@lovesegfault
Copy link
Author

Ah, interesting, would it be in scope for this crate to support historical platforms (i.e. this is a bug) or no (i.e. wontfix)?

@tarcieri
Copy link
Member

tarcieri commented Feb 9, 2024

It's something we could potentially do, although the current approach is to present what stable supports

@Shnatsel
Copy link
Member

Shnatsel commented Feb 9, 2024

Actually we track nightly because Rust documentation does. The platforms crate is auto-generated, and some of the inputs for it are in the documentation, so we have no choice but to track whatever channel the Rust docs do.

We could keep removed platforms around, but that would require additional complexity in the generator. I'd accept a PR implementing it, but I won't write it myself since I have bigger fish to fry.

@Shnatsel Shnatsel changed the title Missing target triples present in channel manifests Record historical, no longer supported target triples in platforms crate Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants