Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on database.fetch config is confusing #1072

Open
Nemo157 opened this issue Nov 23, 2023 · 0 comments
Open

Documentation on database.fetch config is confusing #1072

Nemo157 opened this issue Nov 23, 2023 · 0 comments

Comments

@Nemo157
Copy link

Nemo157 commented Nov 23, 2023

According to the config documentation

/// Perform a `git fetch` before auditing (default: true)
pub fetch: bool,

but the actual logic appears to be

config.database.fetch |= !self.no_fetch;

so setting fetch = false (which is the actual default) only means that --no-fetch will work, but it will still fetch it with default CLI commands; while setting fetch = true overrides --no-fetch and forces fetching the database always even if you try to stop it for one command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant