Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further limits on expensive path building #163

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 5, 2023

This is intended to be complementary to #160 and addresses briansmith/webpki#276 in the same manner as NSS libmozpkix.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #163 (1af0ee0) into main (659167f) will increase coverage by 0.06%.
The diff coverage is 87.95%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   96.56%   96.62%   +0.06%     
==========================================
  Files          15       15              
  Lines        4364     4480     +116     
==========================================
+ Hits         4214     4329     +115     
- Misses        150      151       +1     
Files Changed Coverage Δ
src/error.rs 54.90% <37.50%> (-0.21%) ⬇️
src/verify_cert.rs 97.83% <100.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for tidying up some of the surrounding code. I peeked at the diff coverage dip and it's specific to the error ranking changes (which are much appreciated).

@ctz ctz added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 99b64c5 Sep 5, 2023
46 of 48 checks passed
@ctz ctz deleted the jbp-expensive-path-building branch September 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants