Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: disable comments #187

Merged
merged 1 commit into from
Nov 1, 2023
Merged

codecov: disable comments #187

merged 1 commit into from
Nov 1, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Nov 1, 2023

Turn off codecov leaving comments on PRs based on the doc suggestion.

Resolves #186

@cpu cpu self-assigned this Nov 1, 2023
@cpu cpu mentioned this pull request Nov 1, 2023
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm both okay with disabling diff comments as well as disabling them completely, and if latter is needed to get former, then I prefer not having comments at all.

@cpu
Copy link
Member Author

cpu commented Nov 1, 2023

I'm both okay with disabling diff comments as well as disabling them completely

👍 Let's land this config and see how it goes. If it leaves comments that are still noisy I'll tweak it. We can try more complicated partially enabled configurations down the road.

I don't think we need to wait on djc for this so I'm going to merge.

@cpu cpu added this pull request to the merge queue Nov 1, 2023
Merged via the queue into rustls:main with commit 0318d2f Nov 1, 2023
15 checks passed
@cpu cpu deleted the cpu-silence-codecov branch November 1, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov bot
2 participants