Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential panic #2755

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Fix potential panic #2755

merged 3 commits into from
Apr 3, 2023

Conversation

xiaopengli89
Copy link
Contributor 

uncaught panic: "attempt to divide by zero" at /Users/X20230112120246_ssea_lrtse_cpfx/.cargo/git/checkouts/winit-c2fdb27092aba5a7/3fd7384/src/platform_impl/macos/monitor.rs:233:19
  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

madsmtm
madsmtm approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@madsmtm madsmtm merged commit 2486f0f into rust-windowing:master Apr 3, 2023
53 of 55 checks passed
kchibisov pushed a commit to kchibisov/winit that referenced this pull request May 3, 2023
@xiaopengli89 @kchibisov
Fix potential panic (rust-windowing#2755)
31f347b 
* Fix potential panic

* Update CHANGELOG.md

* Use checked_div

---------

Co-authored-by: Xiaopeng Li <lixiaopeng.jetspark@bytedance.com>
kchibisov pushed a commit that referenced this pull request May 4, 2023
@xiaopengli89 @kchibisov
Fix potential panic (#2755)
d37dac8 
* Fix potential panic

* Update CHANGELOG.md

* Use checked_div

---------

Co-authored-by: Xiaopeng Li <lixiaopeng.jetspark@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

@daxpedda daxpedda Awaiting requested review from daxpedda

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaopengli89 @daxpedda @madsmtm