Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan to new release version? #855

Closed
darren-fu opened this issue Jan 22, 2024 · 6 comments
Closed

plan to new release version? #855

darren-fu opened this issue Jan 22, 2024 · 6 comments

Comments

@darren-fu
Copy link

darren-fu commented Jan 22, 2024

is there a plan to release new version and publish to crates.io?

@exabytes18
Copy link
Contributor

+1.

For reference, the slow release cadence is annoying for organizations who wish to publish crates that depend on rust-rocksdb and want to use any of the improvements in the past 9-month (time since last release). This stems from the fact that crate registries typically don't allow publishing crates with a git dependencies, meaning crates are restricted to only referencing up to the latest published version (0.21.0), which is getting pretty old at this point. Alternatively, those who need to publish their own crate which depends on newer unreleased features of rust-rocksdb can publish a shadow copy of rust-rocksdb crate under a different name, but that's very clunky.

My ask would be: could the rust-rocksdb maintainers publish releases more regularly?

@girlbossceo
Copy link

There has even been fixes relating to database corruption. This should have certainly prompted a release. There was another maintainer added to the project, why is there a lack of interest in publishing new releases?

https://github.com/facebook/rocksdb/releases/tag/v8.5.3

Please note 8.5.1 includes a fix for a persisted database corruption in an unlikely edge case. Upgrading to a version including this fix, like this one, is highly recommended!

https://github.com/facebook/rocksdb/releases/tag/v8.6.7

Added enhanced data integrity checking on SST files with new format_version=6. Performance impact is very small or negligible. Previously if SST data was misplaced or re-arranged by the storage layer, it could pass block checksum with higher than 1 in 4 billion probability. With format_version=6, block checksums depend on what file they are in and location within the file. This way, misplaced SST data is no more likely to pass checksum verification than randomly corrupted data. Also in format_version=6, SST footers are checksum-protected.

@zaidoon1
Copy link
Contributor

zaidoon1 commented Feb 6, 2024

There was another maintainer added to the project, why is there a lack of interest in publishing new releases?

I have requested access to publish crates but I still don't have it, I'm hoping once/if I get access, I can do more regular releases. However, we still need more mainters as both aleksuss and stanislav-tkach don't have enough time to maintain this repo and we ideally need at least two active mainters so we can review prs, etc.. If more people apply and get granted access to maintain, the situation will improve.

@niklasf was interested to become a maintainer at some point (#750). If you are still interested maybe we can push to get you approved?

@aleksuss
Copy link
Member

aleksuss commented Feb 6, 2024

@zaidoon1 I guess you can prepare the release PRs. I will publish it.

@girlbossceo
Copy link

Are we able to track the progress of actually making a new release? Can we help in any way possible to get a release going?

What is the actual true blocker here for a new release besides "more maintainers"?

@zaidoon1 said they've wanted to make a new release but are pending permissions. @aleksuss said an upcoming release is happening (#858 (comment)).

There has to be some other issue that's not being told here. What can we do to help? A new release with the latest RocksDB is all that's really being asked here, and in the future more frequent releases when RocksDB is updated, nothing else.

@zaidoon1
Copy link
Contributor

As I've said, I don't have permission to publish new versions and my requirements for my projects have changed to require me to have the latest dependencies/rust versions/rocksdb version so I have forked this repo: https://github.com/zaidoon1/rust-rocksdb and now maintain my own version that uses the latest version of rust/rocksdb/dependencies and have published this.

My fork will continue to follow this repo in the sense that any new features added to this repo will be added to my fork and I will try my best to review prs in this repo to keep things moving, however, as I've said, I don't have permissions to publish and this repo requires at least another approval to merge any pr (or wait 2 weeks per the wiki). Given that other maintainers are not actively maintaining this repo (understanbly since they are busy with other things), this repo will not have fast releases unless more active maintainers are added/given permission to publish.

If my fork suits your need, feel free to use it and I welcome an prs to improve things.

girlbossceo added a commit to girlbossceo/conduwuit that referenced this issue Feb 11, 2024
https://github.com/zaidoon1/rust-rocksdb

rust-rocksdb/rust-rocksdb#855 (comment)

shame that this has resulted in yet another fork of software, but oh well...

Signed-off-by: strawberry <strawberry@puppygock.gay>
girlbossceo added a commit to girlbossceo/conduwuit that referenced this issue Feb 12, 2024
https://github.com/zaidoon1/rust-rocksdb

rust-rocksdb/rust-rocksdb#855 (comment)

shame that this has resulted in yet another fork of software, but oh well...

Signed-off-by: strawberry <strawberry@puppygock.gay>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants