Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermit: use sys_read_entropy syscall #333

Merged
merged 2 commits into from Feb 9, 2023
Merged

Hermit: use sys_read_entropy syscall #333

merged 2 commits into from Feb 9, 2023

Conversation

newpavlov
Copy link
Member

The syscall was implemented in hermit-os/kernel#640

On non-x86 targets it will return -ENOSYS (which, frankly, IMO is quite bad), but I would say it's outside of our area of responsibility.

cc @joboet @stlankes

@josephlr
Copy link
Member

I agree that handing which platform Hermit supports is not our job, so this implementation should be fine.

Could we add a documentation link?

@newpavlov
Copy link
Member Author

I couldn't find a documentation to which we could link, so the only option for now is to link the source code. I am not sure such link would be useful.

@josephlr
Copy link
Member

I couldn't find a documentation to which we could link, so the only option for now is to link the source code. I am not sure such link would be useful.

I think linking to the system crate (which is the preferred interface to Hermit) would be appropriate: https://hermitcore.github.io/libhermit-rs/hermit/fn.sys_read_entropy.html

@newpavlov
Copy link
Member Author

Ah, good find!

src/hermit.rs Show resolved Hide resolved
src/hermit.rs Show resolved Hide resolved
src/hermit.rs Show resolved Hide resolved
@josephlr josephlr merged commit 7c83ea0 into master Feb 9, 2023
@josephlr josephlr deleted the hermit_syscall branch February 9, 2023 22:00
@newpavlov newpavlov mentioned this pull request Apr 2, 2023
@hugusmaximus
Copy link

I couldn't find a documentation to which we could link, so the only option for now is to link the source code. I am not sure such link would be useful.

I think linking to the system crate (which is the preferred interface to Hermit) would be appropriate: https://hermitcore.github.io/libhermit-rs/hermit/fn.sys_read_entropy.html

This link is broken...

@newpavlov
Copy link
Member Author

@hugusmaximus
The documentation currently uses this link.

@hugusmaximus
Copy link

hugusmaximus commented Jan 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants