Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solaris/OpenBSD/Dragonfly build and re-enable CI #301

Merged
merged 6 commits into from Oct 22, 2022
Merged

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Oct 22, 2022

Fixes #254

This also adds two minor CI improvements:

  • Do a full link on freebsd
  • Build, Link, but don't run on illumos
  • Use the stable toolchain for our Tier 2 Build-only targets
  • Build (via build-std) for Tier 3 targets: openbsd, dragonfly, haiku

Signed-off-by: Joe Richey joerichey@google.com

@josephlr josephlr changed the title Try to fix Solaris build Fix Solaris build and reenable CI Oct 22, 2022
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr marked this pull request as ready for review October 22, 2022 00:42
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr force-pushed the solaris branch 2 times, most recently from 60266ed to 24a2333 Compare October 22, 2022 01:16
@josephlr josephlr changed the title Fix Solaris build and reenable CI Fix Solaris/OpenBSD/Dragonfly build and re-enable CI Oct 22, 2022
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@@ -8,6 +8,7 @@

//! Implementation for OpenBSD
use crate::{util_libc::last_os_error, Error};
use core::mem::MaybeUninit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, good catch.

@josephlr josephlr merged commit d2ca769 into master Oct 22, 2022
@josephlr josephlr deleted the solaris branch October 22, 2022 20:22
@newpavlov newpavlov mentioned this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Solaris cross-build job
2 participants