Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support random file of AIX #282

Merged
merged 3 commits into from Dec 30, 2022
Merged

Support random file of AIX #282

merged 3 commits into from Dec 30, 2022

Conversation

ecnelises
Copy link
Contributor

@ecnelises ecnelises commented Sep 5, 2022

No description provided.

@josephlr
Copy link
Member

josephlr commented Sep 6, 2022

Could we add some IBM docs to justify the implementation choice? I think this is correct, but I've never worked with AIX

@ecnelises
Copy link
Contributor Author

The official doc can be found at https://www.ibm.com/docs/en/aix/7.2?topic=files-random-urandom-devices , this discussion in GnuPG mailing list is also good reference.

In short, the mechanism of /dev/urandom (and /dev/random) on AIX is the same as Linux: the former is more reliable (it never blocks).

@josephlr
Copy link
Member

@ecnelises I'm just wondering if we will have to poll /dev/random like we do on Linux. I don't think we have to, but I'd like to see what OpenSSL does.

@ecnelises
Copy link
Contributor Author

@ecnelises I'm just wondering if we will have to poll /dev/random like we do on Linux. I don't think we have to, but I'd like to see what OpenSSL does.

According to rand_unix.c in OpenSSL, only Linux defines DEVRANDOM_WAIT, and /dev/urandom is in the highest priority by default.

@josephlr josephlr added the waiting on upstream Waiting for upstream changes in an external project label Oct 23, 2022
@josephlr
Copy link
Member

Can you add a row to the documentation in lib.rs about AIX (and link to the official IBM docs).

I think we should also add AIX to the Tier 3 section of our CI. That may require waiting on Rust Nightly to actually understand the target.

@josephlr
Copy link
Member

Note: we are blocked on rust-lang/rust#102293 being merged.

@ecnelises
Copy link
Contributor Author

That PR has been merged :)

@newpavlov newpavlov removed the waiting on upstream Waiting for upstream changes in an external project label Dec 30, 2022
@newpavlov newpavlov merged commit e0e406d into rust-random:master Dec 30, 2022
@newpavlov newpavlov mentioned this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants