Remove buffer zeroing from Node.js implementation #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
approved these changes
Oct 23, 2022
| @@ -5,7 +5,7 @@ | |||
| // <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
| use crate::{util::uninit_slice_fill_zero, Error}; | |||
There was a problem hiding this comment.
After this change, the only other place which uses uninit_slice_fill_zero is the custom backend. It could be worth to inline this function there.
There was a problem hiding this comment.
Ya I was going to clean this up when I cleaned up the custom implementation.
We can use [`Uint8Array::view_mut_raw`](https://rustwasm.github.io/wasm-bindgen/api/js_sys/struct.Uint8Array.html#method.view_mut_raw) which was [added](rustwasm/wasm-bindgen#1850) in version `0.2.54` of `wasm-bindgen`. This method was introduced to deal with uninitialized memory, see the Safety comment for more info. Signed-off-by: Joe Richey <joerichey@google.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
Uint8Array::view_mut_rawwhich was added in version0.2.54ofwasm-bindgen. This method was introduced to deal with uninitialized memory, see theSafetycomment for more info.Signed-off-by: Joe Richey joerichey@google.com