Add support for forced custom implementation #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We intentionally did not want an easy way for users to overwrite the "default" sources on supported platforms, since it may cause security issues. Imagine a crate which silently enables the If users absolutely need to use a different entropy source on supported platforms, then they always can override |
|
I agree with @newpavlov here. We don't want to allow unilateral overriding of the RNG, and there are other ways to achieve your goal here. Note that when we add #275, it may help your use-case, as you could then link against a different getentropy. I'm going to leave #230 open, as it deals with out desired preference for |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature
force-customthat will supersedetarget_osbased rng selection.This fixes #230, and supports my particular use case, which is building for
wasm32-unknown-unknownin theory, but usingwasm32-unknown-emscriptenin practice, with a custom rand impl.