Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checkpointing in the installer, to avoid restarting downloads from zero if they fail #3776

Open
apps4uco opened this issue Apr 19, 2024 · 3 comments
Milestone

Comments

@apps4uco
Copy link

Problem you are trying to solve

On networks that are not 100% reliable, ie mobile broadband in developing countries, at least when using the curl | sh installer, if there is a network problem the installation process starts from zero.

It appears that using the current installer the whole process has to complete for rustup to be installed, at least following the instructions present on the website.

Solution you'd like

Id like to propose that the rustup installer, perform an install of rustup first, so that if the install fails for any reason that rerunning the installer uses the rustup it already installed, so that then rustup can start from the last download that failed.

Notes

To start from zero each time is a waste of your servers bandwidth, and a waste of time and data plan for end users.

Thank you for considering this enhancement.

@rami3l rami3l added this to the On Deck milestone Apr 19, 2024
@rami3l
Copy link
Member

rami3l commented Apr 19, 2024

@apps4uco Thanks for filing this issue! This is surely a thing to be considered.

@rami3l
Copy link
Member

rami3l commented May 3, 2024

@apps4uco I just checked, it turns out that we actually have download checkpointing in the rustup mode right now, so I assume you're referring to the rustup-init mode?

@apps4uco
Copy link
Author

apps4uco commented May 4, 2024

@apps4uco I just checked, it turns out that we actually have download checkpointing in the rustup mode right now, so I assume you're referring to the rustup-init mode?

Sure, I mean the initial install, I must admit I havent looked at the code, but from an outside perspective, it seems as if the rustup installer were to check if rustup had already been installed if not install rustup, then run rustup the problem I mentioned would be solved.

What I experienced is that the whole install process has to succeed, or else it restarts from zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants