-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checksum files for manual installation #3693
Comments
@darthbanana13 Thanks for filing this issue! This does look like an oversight. Related code: Line 6 in 8ff2ec4
Lines 9 to 13 in 8ff2ec4
@rust-lang/release Does our CI/CD somehow rely on the binary path in the shasum file? |
I have no idea, and doubt anyone knows off hand. It's certainly plausible that downstream people consuming the file (if it's exposed) do though. |
... in this case I guess the best thing to do is to fix the error no matter what. A potential downstream relying on our error seems strange and definitely a thing to be fixed anyway. |
I've sent the fix. Guess we'll know if it breaks anything when v1.27.1 lands :] |
Problem
If installation is attempted with the manual method, documented here: https://rust-lang.github.io/rustup/installation/other.html, a download tool with an automatic checksum verifier fails because the path for downloaded file has a path prepended.
Steps
For example with ansible:
Create a local hosts.yaml file:
Create a playbook.yaml:
Create role directory.
In it use command:
ansible-glalaxy init rustup
To create an empty role.
Edit main.yaml in tasks to:
Run the playbook from the plabook file location:
ansible-playbook -i hosts.yaml bootstrap.pb.yaml
See error:
FAILED! => {"changed": false, "msg": "Unable to find a checksum for file 'rustup-init' in 'https://static.rust-lang.org/rustup/dist/armv7-unknown-linux-gnueabihf/rustup-init.sha256'"}
Possible Solution(s)
Use only the executable name in the sha256 file. Instead of:
f21c44b01678c645d8fbba1e55e4180a01ac5af2d38bcbd14aa665e0d96ed69a *target/armv7-unknown-linux-gnueabihf/release/rustup-init
use:
f21c44b01678c645d8fbba1e55e4180a01ac5af2d38bcbd14aa665e0d96ed69a ./rustup-init
or
f21c44b01678c645d8fbba1e55e4180a01ac5af2d38bcbd14aa665e0d96ed69a rustup-init
Examples of other projects doing it with only the executables in the sha file:
Neovim
Mise
Notes
No response
Rustup version
Rustup was not installed
Installed toolchains
Rustup was not installed
The text was updated successfully, but these errors were encountered: