Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup should not delete the entire ~/.rustup/tmp dir #2246

Open
tesuji opened this issue Mar 1, 2020 · 2 comments
Open

rustup should not delete the entire ~/.rustup/tmp dir #2246

tesuji opened this issue Mar 1, 2020 · 2 comments

Comments

@tesuji
Copy link
Contributor

tesuji commented Mar 1, 2020

Rustup should only remove the tmp/<toolchain> dir that it downloaded

When rustup-toolchain-install-master (RTIM) and rustup update run concurrently, rustup often finishs
installation first (probably because of nightly toolchain is cache by cloudfont, I don't know), so
the tmp is removed by rustup. This cause RTIM fails to install the master toolchain.

Describe the solution you'd like

I don't have a clear suggestion. But I think rustup could keep the tmp dir, and only remove
the toolchain that it is going to install.

Notes

@tesuji tesuji changed the title rustup should not only delete the entire ~/.rustup/tmp dir rustup should not delete the entire ~/.rustup/tmp dir Mar 1, 2020
@kinnison
Copy link
Contributor

kinnison commented Mar 8, 2020

At this time rustup does not support being run in parallel for any activity which could use or alter toolchains. I believe @rbtcollins is considering locking approaches to ameliorate this kind of issue.

The post full rustup update temp dir cleanup is explicitly there as a way to resolve issues with partially downloaded content which is not longer referenceable (e.g. cancelled nightly updates)

@rbtcollins
Copy link
Contributor

This is possibly a dupe of #988, possibly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants