suggestion from nonminimal_bool with integer cast creates a syntax error due to parentheses removal

[expectedjoe]

Summary

When a bool expression is not minimal and the result is cast to an integer, the lint can "forget" the correct parentheses order triggering incorrect suggestions.

Reproducer

I tried this code:

fn f(a: i32) -> bool {
    !(1 >= 2) as i32 == a
}

I expected to see this suggested:

fn f(a: i32) -> bool {
    (1 < 2) as i32 == a
}

Instead, clippy suggested:

 --> src/main.rs:2:5
  |
2 |     !(1 >= 2) as i32 == a
  |     ^^^^^^^^^ help: try: `1 < 2`

and cargo clippy --fix produced:

error: comparison operators cannot be chained
 --> src/main.rs:2:7
  |
2 |     1 < 2 as i32 == a
  |       ^          ^^
  |
help: parenthesize the comparison
  |
2 |     (1 < 2 as i32) == a
  |     +            +

error: aborting due to 1 previous error

which is additionally not a good suggestion since (1 < 2 as i32) == a has a type error.

Version

rustc 1.80.0-nightly (d2d24e395 2024-05-03)
binary: rustc
commit-hash: d2d24e395a1e4fcee62ca17bf4cbddb1f903af97
commit-date: 2024-05-03
host: aarch64-apple-darwin
release: 1.80.0-nightly
LLVM version: 18.1.4

Additional Labels

@rustbot label +l-suggestion-causes-error