Generate C-String literals c"example" instead of unsafe code
#2996
+45
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
cstr-gen
branch
5 times, most recently
from
94480f7 to
195e222
Compare
Merged
When `generate_cstr` is enabled, and the target rust version is >= 1.77, generate `c"..."` literals instead of the unsafe `from_bytes_with_nul_unchecked` calls.
nyurik
changed the title
c"example" instead of unsafe code
nyurik
added a commit
to nyurik/rust-bindgen
that referenced
this pull request
Nov 29, 2024
While not used in this PR, this will allow different code generation depending on the language target, e.g. for rust-lang#2996 Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024.
nyurik
added a commit
to nyurik/rust-bindgen
that referenced
this pull request
Nov 29, 2024
While not used in this PR, this will allow different code generation depending on the language target, e.g. for rust-lang#2996 Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024.
emilio
approved these changes
Nov 29, 2024
nyurik
added a commit
to nyurik/rust-bindgen
that referenced
this pull request
Nov 29, 2024
While not used in this PR, this will allow different code generation depending on the language target, e.g. for rust-lang#2996 Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024.
nyurik
added a commit
to nyurik/rust-bindgen
that referenced
this pull request
Nov 29, 2024
While not used in this PR, this will allow different code generation depending on the language target, e.g. for rust-lang#2996 Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024.
nyurik
added a commit
to nyurik/rust-bindgen
that referenced
this pull request
Nov 29, 2024
While not used in this PR, this will allow different code generation depending on the language target, e.g. for rust-lang#2996 Introduce a new `--rust-edition` parameter with allowed values 2015, 2018, 2021, and 2024.
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
generate_cstris enabled, and the target rust version is >= 1.77, generatec"..."literals instead of the unsafefrom_bytes_with_nul_uncheckedcalls. Note that this requires 2021 edition, but since this is not on by default, and CStr support is relatively recent, i think it is ok to tie them togetherNote that this also resolves the Clippy 1.83's manual_c_str_literals issue
Fixes #2994