Remove lazy_static and lazycell dependencies #2817
Closed
+61
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GKFX
force-pushed
the
remove-lazy-dependencies
branch
2 times, most recently
from
a0d771d to
4a8bdd9
Compare
|
CI appears to be broken - https://github.com/rust-lang/rust-bindgen/actions/runs/8853618923/job/24314890579?pr=2817 fails with all changes on this branch reverted. |
|
Huh, it literally was passing yesterday... It seems it's failing trying to load x86-64 clang on an arm macos system, maybe a change on the architecture of the macOS machine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was moved into the standard library, with a slightly different API, in Rust 1.70 (June 2023). As this was nearly a year ago now I think this is a reasonable MSRV bump. (The change to quickchecking makes use of
Mutex::newnow being const.)