removing unused imports generates invalid `use module_name::self` #17139

harrysarson · 2024-04-25T12:34:02Z

rust-analyzer version: rust-analyzer version: 0.3.1932-standalone (47a901b 2024-04-21)

rustc version: rustc 1.79.0-nightly (ef8b9dcf2 2024-04-24)

editor or extension: VScode v0.3.1932

code snippet to reproduce:

mod inner {
    pub struct X();
    pub struct Y();
}

mod z {
    use super::inner::{self, X}$0;

    fn f() {
        let y = inner::Y();
    }
}

becomes

mod inner {
    pub struct X();
    pub struct Y();
}

mod z {
    use super::inner:self;

    fn f() {
        let y = inner::Y();
    }
}

which is invalid. It should be use super::inner instead.

The text was updated successfully, but these errors were encountered:

harrysarson added the C-bug Category: bug label Apr 25, 2024

harrysarson changed the title ~~removing unused imports generates invalid use module_name::self cccccbhlfveedtugibljctridfritbcigrkntnultrr~~ removing unused imports generates invalid use module_name::self Apr 25, 2024

harrysarson mentioned this issue Apr 25, 2024

handle {self} when removing unused imports #17140

Merged

bors closed this as completed in e3e22c6 May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removing unused imports generates invalid `use module_name::self` #17139

removing unused imports generates invalid `use module_name::self` #17139

harrysarson commented Apr 25, 2024 •

edited

removing unused imports generates invalid use module_name::self #17139

removing unused imports generates invalid use module_name::self #17139

Comments

harrysarson commented Apr 25, 2024 • edited

removing unused imports generates invalid `use module_name::self` #17139

removing unused imports generates invalid `use module_name::self` #17139

harrysarson commented Apr 25, 2024 •

edited