Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-deterministic precision for float operations that do not have guaranteed precision #3555

Open
RalfJung opened this issue May 4, 2024 · 1 comment
Open

Use non-deterministic precision for float operations that do not have guaranteed precision #3555

RalfJung opened this issue May 4, 2024 · 1 comment
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available

Comments

@RalfJung
Copy link
Member

RalfJung commented May 4, 2024

As per rust-lang/rust#124609, these operations behave non-deterministically, so we should implement that in Miri. The apply_random_float_error function (currently only used for x86 intrinsics) could be used to do that.
@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-shims Area: This affects the external function shims E-good-first-issue A good way to start contributing, mentoring is available labels May 4, 2024
@RalfJung
Copy link
Member Author

This should also be used for fast-math and "algebraic" float operations.

@RalfJung RalfJung mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RalfJung