Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-miri: incorrect behavior when --target is given multiple times #3460

Open
RalfJung opened this issue Apr 9, 2024 · 2 comments
Open
Labels
A-cargo Area: affects the cargo wrapper (cargo miri) C-bug Category: This is a bug. E-good-first-issue A good way to start contributing, mentoring is available

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 9, 2024

When --target is given multiple times, Miri thinks we are building the first target, but actually cargo will build the last target.

@RalfJung RalfJung added A-cargo Area: affects the cargo wrapper (cargo miri) E-good-first-issue A good way to start contributing, mentoring is available labels Apr 9, 2024
@bjorn3
Copy link
Member

bjorn3 commented Apr 9, 2024

If you specify --target multiple times, cargo will actually build for every specifies target at the same time, except when doing cargo run where passing multiple --target errors out.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 9, 2024

Ah true, cargo test actually runs the tests multiple times.

So cargo miri test should support that as well then.

@RalfJung RalfJung added the C-bug Category: This is a bug. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cargo Area: affects the cargo wrapper (cargo miri) C-bug Category: This is a bug. E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Development

No branches or pull requests

2 participants