Pass global logger by value, supplied logger by ref #673
+206
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #664
cc @EFanZh @tisonkun @Thomasdezeeuw
This PR ensures we pass loggers by-ref when they're user-supplied, and by-value when it's the built-in global logger. I'll add a few tests to ensure we don't take ownership of the logger in
log!
orlog_enabled!
.