Use the Equivalent trait from the equivalent crate
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows types implementating the `Equivalent` trait to work with other hash table, such as `IndexMap`. See indexmap-rs/indexmap#253.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
cuviper
reviewed
Jul 17, 2023
| @@ -117,6 +117,11 @@ pub mod hash_set { | |||
| pub use crate::map::HashMap; | |||
| pub use crate::set::HashSet; | |||
|
|
|||
| #[cfg(feature = "equivalent")] | |||
| use equivalent::Equivalent; | |||
There was a problem hiding this comment.
Shouldn't this be pub to match the API without the feature?
(or else hide them both in a breaking change)
bors
added a commit
that referenced
this pull request
Jul 18, 2023
Publicly re-export `Equivalent` from the crate root Addresses #442 (comment).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows types implementating the
Equivalenttrait to work with other hash table, such asIndexMap.See indexmap-rs/indexmap#253.