Fix CredentialHelper::add_command #1137
Conversation
aibaars
force-pushed
the
fix-credential-helper
branch
from
16bd0dc to
ef3bca9
Compare
aibaars
force-pushed
the
fix-credential-helper
branch
from
ef3bca9 to
c776e8d
Compare
| fn is_absolute_path(path: &str) -> bool { | ||
| path.starts_with('/') | ||
| || path.starts_with('\\') | ||
| || cfg!(windows) && path.chars().nth(1).is_some_and(|x| x == ':') |
There was a problem hiding this comment.
Just a minor note, this is slightly different from https://github.com/git-for-windows/git/blob/cca1f38702730b35f52c29efd62864b85e85ddcc/compat/win32/path-utils.c#L9-L31, but probably not enough to matter here.
There was a problem hiding this comment.
Yes, git2-rs uses the str type while the git C uses a char* and if I understand the git C code correctly, it just tries to handle the case where the drive letter is a UTF8 character. I'd expect the str::nth function to take care of that already. However, there might indeed be some behaviour differences in corner cases at I'm not aware of.
|
Note that this was relaxed in #429 which previously looked for |
Previously the add_helper function would check whether the command contains a
\or/character to determine whether it is absolute. It should have used starts_with instead of contains. In addition an absolute on Windows a path my start with a drive letter. The git cli implements this by checking if the second character is a ':'.See also: https://github.com/git/git/blob/6a64ac7b014fa2cfa7a69af3c253bcd53a94b428/credential.c#L492-L493
Fixes #1136