Use `Waker::will_wake()` to avoid a cloning op #2723

daxpedda · 2023-03-18T12:35:52Z

This uses Waker::will_wake() to check if the old waker will awaken the same task as the new one, which could save a clone operation.

This is analogous to smol-rs/atomic-waker#12.

taiki-e

Thanks!

daxpedda requested a review from taiki-e as a code owner March 18, 2023 12:35

Use Waker::will_wake() to avoid a cloning op

e12ab28

daxpedda force-pushed the will-wake branch from cbd393f to e12ab28 Compare March 18, 2023 12:36

taiki-e approved these changes Mar 22, 2023

View reviewed changes

taiki-e merged commit cc0e342 into rust-lang:master Mar 22, 2023

taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label Mar 22, 2023

taiki-e pushed a commit that referenced this pull request Mar 30, 2023

Use Waker::will_wake() to avoid a cloning op (#2723)

472f556

taiki-e mentioned this pull request Mar 30, 2023

Release 0.3.28 #2735

Merged

taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Mar 30, 2023

taiki-e pushed a commit that referenced this pull request Mar 30, 2023

Use Waker::will_wake() to avoid a cloning op (#2723)

94e020d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Waker::will_wake()` to avoid a cloning op #2723

Use `Waker::will_wake()` to avoid a cloning op #2723

daxpedda commented Mar 18, 2023

taiki-e left a comment

Use Waker::will_wake() to avoid a cloning op #2723

Use Waker::will_wake() to avoid a cloning op #2723

Conversation

daxpedda commented Mar 18, 2023

taiki-e left a comment

Choose a reason for hiding this comment

Use `Waker::will_wake()` to avoid a cloning op #2723

Use `Waker::will_wake()` to avoid a cloning op #2723