Ensure unreachable branch is eliminated #2708
Merged
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2704, I introduced two
unwrap()
calls inSelect::poll
, but I found that withopt-level=z
, the compiler won’t be able to optimize theseunwrap()
calls, so maybe changing them tounwrap_unchecked()
is a better idea? See https://godbolt.org/z/cef118zKe for comparison withopt-level=z
.Also, since
unwrap_unchecked()
is introduced in Rust 1.58.0, I have to implement this function manually.