add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` #400

folkertdev · 2024-04-16T18:00:04Z

This PR adds (experimental) support for using flate2 with the zlib-rs backend. The zlib-rs crate is a pure-rust implementation of the zlib api that makes use of SIMD to achieve performance close to zlib-ng (currently 5% to 10% slower).

For the moment, the libz-rs-sys C api is used for the integration. At some point in the future, zlib-rs will get a more convenient rust api that will require less (hopefully no) unsafe code.

cc @joshtriplett

folkertdev · 2024-04-16T18:02:04Z

src/ffi/c.rs

+                // for zlib-rs, it is most efficient to have it provide the allocator.
+                // The libz-rs-sys dependency is configured to use the rust system allocator
+                #[cfg(all(feature = "any_zlib", feature = "libz-rs-sys"))]
+                zalloc: None,
+                #[cfg(all(feature = "any_zlib", feature = "libz-rs-sys"))]
+                zfree: None,


the trick is that because zlib-rs can do equality comparisons on the function pointer, it can know when its built-in allocator is used, and this allocator guarantees 64-byte alignment. The allocation of zfree and zalloc below is not needed (and that implementation is less efficient to deal with allignment).

folkertdev · 2024-04-16T18:02:37Z

src/ffi/c.rs

@@ -75,54 +87,65 @@ impl Drop for StreamWrapper {
    }
 }

-const ALIGN: usize = std::mem::align_of::<usize>();
+#[cfg(all(feature = "any_zlib", not(feature = "libz-rs-sys")))]


in the case of zlib-rs, the allocator logic is unused. That is an error for this crate, so it's only conditionally compiled now.

src/ffi/c.rs

folkertdev · 2024-04-16T18:14:26Z

.github/workflows/main.yml

@@ -43,6 +43,8 @@ jobs:
      if: matrix.build != 'mingw'
    - run: cargo test --features zlib-ng --no-default-features
      if: matrix.build != 'mingw'
+    - run: cargo test --features zlib-rs --no-default-features
+      if: matrix.build != 'mingw'


we should eventually be able to compile on mingw, but the current release doesn't, and we don't test for it, so disabling for now.

This will need fixing before we could consider it as a potential default, but it's fine for now.

Byron

Thanks a lot for contributing what could one day be the new default backend, and replace minizoxide in this space.

As CI is failing on Windows, I think that might be a good reason to run tests on Windows (and maybe more) platforms as well.

Further, when looking at the dependencies of libz-rs-sys, I was surprised that zlib-rs has what looks like test-dependencies as part of its normal dependencies. It's clear that these are optional and behind features, but I would have thought that dev-dependencies work fine for unit-tests as well. It somehow worried me that this (what seems like a) workaround was necessary, and I hoped there is another way. Maybe APIs could be made public behind a hidden feature toggle, and a separate test-only crate could carry all the dependencies? Then the separation would be clear, and maybe some test-specific code could be extracted into a separate space. This comment is probably not relevant to this PR though, merely a side-note.

I would definitely wait for CI to be fixed, and a second reviewer.

src/ffi/c.rs

folkertdev · 2024-04-17T08:39:50Z

thanks for the review

we're working on windows support (already merged into our main branch but needs a little cleanup still). Should be ready soon.
the dependency situation is kind of nasty. From what I observe, it seems that if crate A has a dev-dependency on crate B, then crate B is not compiled with cfg(test) to be true. Our crate B needs to expose/derive things for testing in crate A. So, we haven't yet found a better solution than the feature flags, but it is far from ideal, I'd really like to not be doing that.
we've been in regular contact with @joshtriplett so he'd be a natural second reviewer here.

Byron · 2024-04-17T12:37:55Z

That all is great to hear!

Regarding the testing, thanks for the explanation - I understand now why these test-dependencies can't be dev-dependencies.

Besides that, I think with Josh approving this PR, it can be merged.

oyvindln · 2024-04-17T13:10:48Z

Thanks a lot for contributing what could one day be the new default backend, and replace minizoxide in this space.

Well it would have been nice to have some help to improve miniz-oxide rather than creating yet another rust deflate implementation I guess... but i digress

Byron · 2024-04-17T13:23:42Z

My apologies, that callout what unnecessary, and lacked the appreciation that is due for it as the backend which just works. I got carried away by the pure-Rust-powered zlib-ng like performance as default here, it's something that gitoxide benefits from a lot.

But maybe this could be a starting point for eventually bringing both projects together (without having any idea if this is technically or even legally possible).

oyvindln · 2024-04-18T00:58:38Z

Ah sorry, maybe I came across as overly grumpy, wasn't meant for you or anyone in particular, it's just happened a few times now. I kinda expect miniz-oxide to be obsoleted eventually unless someone else comes along and picks it up as I'm not really in a position to actively put in a lot of work into it myself - as of now I guess zlib-rs has some different aims though as it makes rather heavy use of unsafe code and probably has to keep doing so as long as explicit SIMD requires it.

Byron · 2024-04-18T05:29:16Z

Right, thanks for clarifying this! If miniz-oxide is 100% safe Rust, there is value in that alone, independently of performance. Then, even if zlib-rs is equivalent functionally and regarding portability, figuring out what the default backend should be wouldn't be straightforward anymore and probably stay as is :).

folkertdev · 2024-04-20T13:18:56Z

We certainly have no ill will versus miniz-oxide: it's simple, small, consistent between platforms, no unsafe besides some C api stuff, and performs slightly better than the original zlib, which is perfectly adequate for many use cases.

zlib-rs is more ambitious though: it aims to match zlib-ng performance and properly provide the full zlib api, meaning that we can create a drop-in replacement for the zlib dynamic library.

I'm not sure a generic, shared deflate implementation works, but we're happy to share code/knowlegde. It is our impression however that the majority of performance improvements stem from the explicit use of SIMD instructions, which miniz-oxide does not seem to want to use?

We believe to have fixed the windows issues. I'll try that here on CI now by setting the dependency to a git branch again. This should not be merged in that state. I'll report back after we've pushed another release to crates.io and think this is ready.

oyvindln · 2024-04-20T16:58:54Z

It is our impression however that the majority of performance improvements stem from the explicit use of SIMD instructions, which miniz-oxide does not seem to want to use?

We don't want to use any unsafe code in miniz_oxide (external C api requires it of course but that's a separate thing), and as far as I know at least there isn't any way to use explicit SIMD without unsafe on stable rust (the portable simd API could help solve that but it seems to have been stalled as of now). There may be some crates out there that implement something similar though those again will be using unsafe internally.

To what extent explicit SIMD is needed to reach performance parity and to what extent it can be achieved with autovectorization with the right code layout I don't know.

In any case zlib-rs will now provide a rust alternative to using the C implementation of zlib-ng that's close to the same performance for users that are okay with the safety tradeoffs (and that hopefully won't be patched out by debian maintainers like zlib-ng is)

folkertdev · 2024-04-20T18:39:52Z

The explicit SIMD is essential, e.g. https://github.com/memorysafety/zlib-rs/blob/main/zlib-rs/src/deflate/compare256.rs#L170, LLVM just can't see that idea with the wide comparison and bit counting.

There are a couple of tricks around breaking dependency chains in the bit reader that you may benefit from. E.g. https://github.com/Frommi/miniz_oxide/blob/master/miniz_oxide/src/inflate/core.rs#L423 the if here is very prone to misprediction. The optimized implementations just always add more bits to the buffer, e.g. we https://github.com/memorysafety/zlib-rs/blob/main/zlib-rs/src/inflate/bitreader.rs#L103 have no branches in that function at all. A bounds check would be acceptable because it is easy to predict.

What's the story behind removing zlib-ng from the flate2 debian package?

folkertdev · 2024-04-22T10:18:21Z

We have released version 0.1.1 that fixes various issues on windows and macos (x86 and aarch64). These targets are now tested in our CI so there should be no regressions.

From my side this PR is now done and ready to be merged

Byron

Thanks a lot for all your hard work and for seeing it through!

The only concern I have is that this CI is testing more platforms than the zlib-rs CI (even though Windows checks were added now), and I hope that this isn't prone to unexpected breakage here.

Then, I will leave it for @joshtriplett to finalize the review and possibly merge as well.

folkertdev · 2024-04-23T07:50:21Z

What platforms do we miss? mingw is deliberately omitted for now. I guess we could add a build with the nightly target?

https://github.com/memorysafety/zlib-rs/blob/main/.github/workflows/checks.yaml#L25

Byron · 2024-04-24T05:03:50Z

Actually, I confused this repo with the one from libz which builds on many, many different platforms. Here it's indeed only mingw that isn't tested in zlib-rs. I think my argument could still apply, but much more weakly.

I don't think that nightly should play a role as nightly shouldn't ever break anything (and if it does, it's a bug that will be fixed before it hits stable).

joshtriplett · 2024-04-24T18:54:11Z

Cargo.toml

@@ -19,6 +19,7 @@ and raw deflate streams.
 [dependencies]
 libz-sys = { version = "1.1.8", optional = true, default-features = false }
 libz-ng-sys = { version = "1.1.8", optional = true }
+libz-rs-sys = { version = "0.1.1", optional = true, default-features = false, features = ["std", "rust-allocator"] }


libz-rs-sys has default = ["std", "rust-allocator"]. What's the rationale for disabling default features and then writing them out by hand, here? Defensive programming against future additions to the defaults?

yes exactly. it also clarifies that we're explicitly using the rust allocator; that will always be the default when the crate is used from rust, but not when we build a C dynamic library.

joshtriplett

Looks good to me! Wrote a comment about the feature usage, but I don't think that's a blocker to merging.

folkertdev · 2024-04-24T19:59:44Z

Thanks! would it be possible to make a release with these changes?

Byron · 2024-04-25T06:50:12Z

Yes, cold you create a PR that bumps the version? I can't self-approve my own PRs hence the need for help :).

Byron · 2024-04-26T08:17:45Z

A new release is now available: https://github.com/rust-lang/flate2-rs/releases/tag/1.0.29

torokati44 · 2024-04-28T20:28:38Z

Does the README not mention this because it's still experimental (and therefore shouldn't be used "in production")?

Byron · 2024-04-29T13:36:47Z

That's a good point - it might have been an oversight, and it should probably be mentioned along with a note of being not necessarily production-proven yet.

torokati44 · 2024-04-29T14:23:10Z

I see, thank you. We won't opt into it yet then.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [anyhow](https://togithub.com/dtolnay/anyhow) | dependencies | patch | `1.0.81` -> `1.0.82` | | [encoding_rs](https://docs.rs/encoding_rs/) ([source](https://togithub.com/hsivonen/encoding_rs)) | dependencies | patch | `0.8.33` -> `0.8.34` | | [flate2](https://togithub.com/rust-lang/flate2-rs) | dependencies | patch | `1.0.28` -> `1.0.30` | | [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | dependencies | patch | `1.0.197` -> `1.0.199` | --- ### Release Notes <details> <summary>dtolnay/anyhow (anyhow)</summary> ### [`v1.0.82`](https://togithub.com/dtolnay/anyhow/releases/tag/1.0.82) [Compare Source](https://togithub.com/dtolnay/anyhow/compare/1.0.81...1.0.82) - Documentation improvements </details> <details> <summary>hsivonen/encoding_rs (encoding_rs)</summary> ### [`v0.8.34`](https://togithub.com/hsivonen/encoding_rs/compare/v0.8.33...v0.8.34) [Compare Source](https://togithub.com/hsivonen/encoding_rs/compare/v0.8.33...v0.8.34) </details> <details> <summary>rust-lang/flate2-rs (flate2)</summary> ### [`v1.0.30`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.30): - docs.rs pages should build again [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.29...1.0.30) #### What's Changed - Fix typos by [@striezel](https://togithub.com/striezel) in [rust-lang/flate2-rs#406 - Update actions/checkout in GitHub Actions workflows to v4 by [@striezel](https://togithub.com/striezel) in [rust-lang/flate2-rs#407 - fix CI - `--all-features` wasn't tested and didn't work with arrival of `zlib-rs` by [@Byron](https://togithub.com/Byron) in [rust-lang/flate2-rs#405 #### New Contributors - [@striezel](https://togithub.com/striezel) made their first contribution in [rust-lang/flate2-rs#406 **Full Changelog**: rust-lang/flate2-rs@1.0.29...1.0.30 ### [`v1.0.29`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.29): - with new `zlib-rs` feature (~`zlib-ng` in Rust) [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.28...1.0.29) With the [new `zlib-rs`](https://togithub.com/memorysafety/zlib-rs) feature, a new backend is enabled that brings in a SIMD-accelerated Rust implementation. #### What's Changed - Fix build for beta and nightly by [@JakubOnderka](https://togithub.com/JakubOnderka) in [rust-lang/flate2-rs#388 - Store `StreamWrapper::inner` as a raw pointer by [@icmccorm](https://togithub.com/icmccorm) in [rust-lang/flate2-rs#394 - Avoid redudant imports by [@Byron](https://togithub.com/Byron) in [rust-lang/flate2-rs#398 - add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` by [@folkertdev](https://togithub.com/folkertdev) in [rust-lang/flate2-rs#400 - Add tests to show BufRead can be used after decoding by [@jongiddy](https://togithub.com/jongiddy) in [rust-lang/flate2-rs#402 - release version 1.0.29: support for zlib-rs by [@folkertdev](https://togithub.com/folkertdev) in [rust-lang/flate2-rs#403 #### New Contributors - [@JakubOnderka](https://togithub.com/JakubOnderka) made their first contribution in [rust-lang/flate2-rs#388 - [@icmccorm](https://togithub.com/icmccorm) made their first contribution in [rust-lang/flate2-rs#394 - [@folkertdev](https://togithub.com/folkertdev) made their first contribution in [rust-lang/flate2-rs#400 **Full Changelog**: rust-lang/flate2-rs@1.0.28...1.0.29 </details> <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.199`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.199) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.198...v1.0.199) - Fix ambiguous associated item when `forward_to_deserialize_any!` is used on an enum with `Error` variant ([#2732](https://togithub.com/serde-rs/serde/issues/2732), thanks [@aatifsyed](https://togithub.com/aatifsyed)) ### [`v1.0.198`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.198) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.197...v1.0.198) - Support serializing and deserializing `Saturating<T>` ([#2709](https://togithub.com/serde-rs/serde/issues/2709), thanks [@jbethune](https://togithub.com/jbethune)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/gitext-rs/git-dive).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update compatible [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [annotate-snippets](https://togithub.com/rust-lang/annotate-snippets-rs) | workspace.dependencies | patch | `0.11.1` -> `0.11.2` | | [anyhow](https://togithub.com/dtolnay/anyhow) | workspace.dependencies | patch | `1.0.81` -> `1.0.82` | | [base64](https://togithub.com/marshallpierce/rust-base64) | workspace.dependencies | patch | `0.22.0` -> `0.22.1` | | [color-print](https://gitlab.com/dajoha/color-print) | workspace.dependencies | patch | `0.3.5` -> `0.3.6` | | [flate2](https://togithub.com/rust-lang/flate2-rs) | workspace.dependencies | patch | `1.0.28` -> `1.0.30` | | [indexmap](https://togithub.com/indexmap-rs/indexmap) | workspace.dependencies | patch | `2` -> `2.2.6` | | [jobserver](https://togithub.com/rust-lang/jobserver-rs) | workspace.dependencies | patch | `0.1.28` -> `0.1.31` | | [libc](https://togithub.com/rust-lang/libc) | workspace.dependencies | patch | `0.2.153` -> `0.2.154` | | [pathdiff](https://togithub.com/Manishearth/pathdiff) | workspace.dependencies | patch | `0.2` -> `0.2.1` | | [percent-encoding](https://togithub.com/servo/rust-url) | workspace.dependencies | patch | `2.3` -> `2.3.1` | | [pulldown-cmark](https://togithub.com/raphlinus/pulldown-cmark) | workspace.dependencies | patch | `0.10.2` -> `0.10.3` | | [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.197` -> `1.0.199` | | [serde_json](https://togithub.com/serde-rs/json) | workspace.dependencies | patch | `1.0.115` -> `1.0.116` | | [thiserror](https://togithub.com/dtolnay/thiserror) | workspace.dependencies | patch | `1.0.58` -> `1.0.59` | | [time](https://time-rs.github.io) ([source](https://togithub.com/time-rs/time)) | workspace.dependencies | patch | `0.3` -> `0.3.36` | | [toml_edit](https://togithub.com/toml-rs/toml) | workspace.dependencies | patch | `0.22.11` -> `0.22.12` | | [unicode-width](https://togithub.com/unicode-rs/unicode-width) | workspace.dependencies | patch | `0.1.11` -> `0.1.12` | --- ### Release Notes <details> <summary>rust-lang/annotate-snippets-rs (annotate-snippets)</summary> ### [`v0.11.2`](https://togithub.com/rust-lang/annotate-snippets-rs/blob/HEAD/CHANGELOG.md#0112---2024-04-27) [Compare Source](https://togithub.com/rust-lang/annotate-snippets-rs/compare/0.11.1...0.11.2) ##### Added - All public types now implement `Debug` [#119](https://togithub.com/rust-lang/annotate-snippets-rs/pull/119) </details> <details> <summary>dtolnay/anyhow (anyhow)</summary> ### [`v1.0.82`](https://togithub.com/dtolnay/anyhow/releases/tag/1.0.82) [Compare Source](https://togithub.com/dtolnay/anyhow/compare/1.0.81...1.0.82) - Documentation improvements </details> <details> <summary>marshallpierce/rust-base64 (base64)</summary> ### [`v0.22.1`](https://togithub.com/marshallpierce/rust-base64/blob/HEAD/RELEASE-NOTES.md#0221) [Compare Source](https://togithub.com/marshallpierce/rust-base64/compare/v0.22.0...v0.22.1) - Correct the symbols used for the predefined `alphabet::BIN_HEX`. </details> <details> <summary>dajoha/color-print (color-print)</summary> ### [`v0.3.6`](https://gitlab.com/dajoha/color-print/compare/v0.3.5...v0.3.6) [Compare Source](https://gitlab.com/dajoha/color-print/compare/v0.3.5...v0.3.6) </details> <details> <summary>rust-lang/flate2-rs (flate2)</summary> ### [`v1.0.30`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.30): - docs.rs pages should build again [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.29...1.0.30) ##### What's Changed - Fix typos by [`@striezel](https://togithub.com/striezel)` in [rust-lang/flate2-rs#406 - Update actions/checkout in GitHub Actions workflows to v4 by [`@striezel](https://togithub.com/striezel)` in [rust-lang/flate2-rs#407 - fix CI - `--all-features` wasn't tested and didn't work with arrival of `zlib-rs` by [`@Byron](https://togithub.com/Byron)` in [rust-lang/flate2-rs#405 ##### New Contributors - [`@striezel](https://togithub.com/striezel)` made their first contribution in [rust-lang/flate2-rs#406 **Full Changelog**: rust-lang/flate2-rs@1.0.29...1.0.30 ### [`v1.0.29`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.29): - with new `zlib-rs` feature (~`zlib-ng` in Rust) [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.28...1.0.29) With the [new `zlib-rs`](https://togithub.com/memorysafety/zlib-rs) feature, a new backend is enabled that brings in a SIMD-accelerated Rust implementation. ##### What's Changed - Fix build for beta and nightly by [`@JakubOnderka](https://togithub.com/JakubOnderka)` in [rust-lang/flate2-rs#388 - Store `StreamWrapper::inner` as a raw pointer by [`@icmccorm](https://togithub.com/icmccorm)` in [rust-lang/flate2-rs#394 - Avoid redudant imports by [`@Byron](https://togithub.com/Byron)` in [rust-lang/flate2-rs#398 - add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` by [`@folkertdev](https://togithub.com/folkertdev)` in [rust-lang/flate2-rs#400 - Add tests to show BufRead can be used after decoding by [`@jongiddy](https://togithub.com/jongiddy)` in [rust-lang/flate2-rs#402 - release version 1.0.29: support for zlib-rs by [`@folkertdev](https://togithub.com/folkertdev)` in [rust-lang/flate2-rs#403 ##### New Contributors - [`@JakubOnderka](https://togithub.com/JakubOnderka)` made their first contribution in [rust-lang/flate2-rs#388 - [`@icmccorm](https://togithub.com/icmccorm)` made their first contribution in [rust-lang/flate2-rs#394 - [`@folkertdev](https://togithub.com/folkertdev)` made their first contribution in [rust-lang/flate2-rs#400 **Full Changelog**: rust-lang/flate2-rs@1.0.28...1.0.29 </details> <details> <summary>rust-lang/libc (libc)</summary> ### [`v0.2.154`](https://togithub.com/rust-lang/libc/releases/tag/0.2.154) [Compare Source](https://togithub.com/rust-lang/libc/compare/0.2.153...0.2.154) #### What's Changed - Fix CI on v0.2 by [`@JohnTitor](https://togithub.com/JohnTitor)` in [rust-lang/libc#3589 - \[Backport [#3547](https://togithub.com/rust-lang/libc/issues/3547)] Add ioctl FS_IOC\_{G,S}{ETVERSION,ETFLAGS} for CSKY by [`@Dirreke](https://togithub.com/Dirreke)` in [rust-lang/libc#3572 - Add Linux riscv64 HWCAP defines (libc-0.2) by [`@Xeonacid](https://togithub.com/Xeonacid)` in [rust-lang/libc#3580 - Add missing MIPS R6 FS_IOC_\* definitions by [`@chenx97](https://togithub.com/chenx97)` in [rust-lang/libc#3591 - Support posix_spawn on Android by [`@pcc](https://togithub.com/pcc)` in [rust-lang/libc#3602 - \[0.2] Fix libc-tests for loongarch64 by [`@heiher](https://togithub.com/heiher)` in [rust-lang/libc#3607 - visionOS Support by [`@agg23](https://togithub.com/agg23)` in [rust-lang/libc#3568 - \[0.2] linux/musl: Add support for LoongArch64 by [`@heiher](https://togithub.com/heiher)` in [rust-lang/libc#3606 - v0.2: Fix c_char on AIX by [`@taiki-e](https://togithub.com/taiki-e)` in [rust-lang/libc#3662 - solarish adding SO_EXCLBIND constant. by [`@devnexen](https://togithub.com/devnexen)` in [rust-lang/libc#3651 - \[0.2] Add SIG constants to espidf by [`@Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik)` in [rust-lang/libc#3658 - add all android sysconf constants by [`@fkm3](https://togithub.com/fkm3)` in [rust-lang/libc#3656 - feat: more \_PC_XXX constants for apple targets by [`@SteveLauC](https://togithub.com/SteveLauC)` in [rust-lang/libc#3649 - feat: O_EXEC/O_SEARCH for apple platforms by [`@SteveLauC](https://togithub.com/SteveLauC)` in [rust-lang/libc#3668 - \[0.2] Add constant AT_MINSIGSTKSZ by [`@ur4t](https://togithub.com/ur4t)` in [rust-lang/libc#3637 - Haiku: synchronize with post R1-beta 4 changes in libc by [`@nielx](https://togithub.com/nielx)` in [rust-lang/libc#3638 - adding getentropy/getrandom to dragonflybsd. by [`@devnexen](https://togithub.com/devnexen)` in [rust-lang/libc#3618 - Move strftime, strftime_l, strptime to linux_like by [`@pcc](https://togithub.com/pcc)` in [rust-lang/libc#3600 - update crate version to 0.2.154 by [`@Dirreke](https://togithub.com/Dirreke)` in [rust-lang/libc#3573 #### New Contributors - [`@pcc](https://togithub.com/pcc)` made their first contribution in [rust-lang/libc#3602 - [`@agg23](https://togithub.com/agg23)` made their first contribution in [rust-lang/libc#3568 - [`@Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik)` made their first contribution in [rust-lang/libc#3658 - [`@ur4t](https://togithub.com/ur4t)` made their first contribution in [rust-lang/libc#3637 **Full Changelog**: rust-lang/libc@0.2.153...0.2.154 </details> <details> <summary>raphlinus/pulldown-cmark (pulldown-cmark)</summary> ### [`v0.10.3`](https://togithub.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.10.3) [Compare Source](https://togithub.com/raphlinus/pulldown-cmark/compare/v0.10.2...v0.10.3) The main change of this release is the `simd` feature was not being used in the escape functions since the version 0.10 due to a mistake during the separation of the crate `pulldown-cmark-escape`. The crate `pulldown-cmark-escape` has been updated to the version 0.10.1. #### What's Changed - fix: fix dead code warning from nightly compiler by [`@rhysd](https://togithub.com/rhysd)` in [pulldown-cmark/pulldown-cmark#876 - Eat all spaces after line break in link title by [`@notriddle](https://togithub.com/notriddle)` in [pulldown-cmark/pulldown-cmark#877 - Mark `Rule` as a block item by [`@notriddle](https://togithub.com/notriddle)` in [pulldown-cmark/pulldown-cmark#879 **Full Changelog**: pulldown-cmark/pulldown-cmark@v0.10.2...v0.10.3 </details> <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.199`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.199) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.198...v1.0.199) - Fix ambiguous associated item when `forward_to_deserialize_any!` is used on an enum with `Error` variant ([#2732](https://togithub.com/serde-rs/serde/issues/2732), thanks [`@aatifsyed](https://togithub.com/aatifsyed))` ### [`v1.0.198`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.198) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.197...v1.0.198) - Support serializing and deserializing `Saturating<T>` ([#2709](https://togithub.com/serde-rs/serde/issues/2709), thanks [`@jbethune](https://togithub.com/jbethune))` </details> <details> <summary>serde-rs/json (serde_json)</summary> ### [`v1.0.116`](https://togithub.com/serde-rs/json/releases/tag/v1.0.116) [Compare Source](https://togithub.com/serde-rs/json/compare/v1.0.115...v1.0.116) - Make module structure comprehensible to static analysis ([#1124](https://togithub.com/serde-rs/json/issues/1124), thanks [`@mleonhard](https://togithub.com/mleonhard))` </details> <details> <summary>dtolnay/thiserror (thiserror)</summary> ### [`v1.0.59`](https://togithub.com/dtolnay/thiserror/releases/tag/1.0.59) [Compare Source](https://togithub.com/dtolnay/thiserror/compare/1.0.58...1.0.59) - Unblock testing of rustc `debug-fmt-detail` option ([#297](https://togithub.com/dtolnay/thiserror/issues/297)) </details> <details> <summary>time-rs/time (time)</summary> ### [`v0.3.36`](https://togithub.com/time-rs/time/blob/HEAD/CHANGELOG.md#0336-2024-04-10) [Compare Source](https://togithub.com/time-rs/time/compare/v0.3.35...v0.3.36) ##### # Fixed - `FormatItem` can be used as part of an import path. See [#675] for details. [#675]: https://togithub.com/time-rs/time/issues/675 ### [`v0.3.35`](https://togithub.com/time-rs/time/blob/HEAD/CHANGELOG.md#0335-2024-04-10) [Compare Source](https://togithub.com/time-rs/time/compare/v0.3.34...v0.3.35) ##### Added - `Duration::checked_neg` - `ext::InstantExt`, which provides methods for using `time::Duration` with `std::time::Instant` ##### Changed - `Instant` is deprecated. It is recommended to use `std::time::Instant` directly, importing `time::ext::InstantExt` for interoperability with `time::Duration`. - `FormatItem` has been renamed to `BorrowedFormatItem`, avoiding confusion with `OwnedFormatItem`. An alias has been added for backwards compatibility. ##### Fixed - The weekday is optional when parsing RFC2822. - The range of sub-second values in `Duration` is documented correctly. The previous documentation contained an off-by-one error. - Leap seconds are now correctly handled when parsing ISO 8601. </details> <details> <summary>toml-rs/toml (toml_edit)</summary> ### [`v0.22.12`](https://togithub.com/toml-rs/toml/compare/v0.22.11...v0.22.12) [Compare Source](https://togithub.com/toml-rs/toml/compare/v0.22.11...v0.22.12) </details> <details> <summary>unicode-rs/unicode-width (unicode-width)</summary> ### [`v0.1.12`](https://togithub.com/unicode-rs/unicode-width/compare/v0.1.11...v0.1.12) [Compare Source](https://togithub.com/unicode-rs/unicode-width/compare/v0.1.11...v0.1.12) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo).

folkertdev commented Apr 16, 2024

View reviewed changes

folkertdev force-pushed the zlib-rs-c-api branch 3 times, most recently from 2f646b2 to e9232c7 Compare April 16, 2024 18:13

folkertdev commented Apr 16, 2024

View reviewed changes

Byron reviewed Apr 17, 2024

View reviewed changes

src/ffi/c.rs Show resolved Hide resolved

src/ffi/c.rs Show resolved Hide resolved

Byron requested a review from joshtriplett April 17, 2024 12:33

add zlib-rs support via the libz-rs-sys C api for zlib-rs

7e6429a

folkertdev force-pushed the zlib-rs-c-api branch from f024b19 to 7e6429a Compare April 22, 2024 10:10

Byron approved these changes Apr 23, 2024

View reviewed changes

joshtriplett reviewed Apr 24, 2024

View reviewed changes

joshtriplett approved these changes Apr 24, 2024

View reviewed changes

joshtriplett merged commit 320e7c7 into rust-lang:main Apr 24, 2024
10 checks passed

folkertdev mentioned this pull request Apr 26, 2024

release version 1.0.29: support for zlib-rs #403

Merged

Byron mentioned this pull request Apr 26, 2024

fix CI - --all-features wasn't tested and didn't work with arrival of zlib-rs #405

Merged

torokati44 mentioned this pull request Apr 28, 2024

build(deps): bump the cargo-minor group with 2 updates ruffle-rs/ruffle#16146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` #400

add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` #400

folkertdev commented Apr 16, 2024

folkertdev Apr 16, 2024

folkertdev Apr 16, 2024

folkertdev Apr 16, 2024

joshtriplett Apr 24, 2024

Byron left a comment

folkertdev commented Apr 17, 2024

Byron commented Apr 17, 2024

oyvindln commented Apr 17, 2024 •

edited

Byron commented Apr 17, 2024

oyvindln commented Apr 18, 2024 •

edited

Byron commented Apr 18, 2024

folkertdev commented Apr 20, 2024

oyvindln commented Apr 20, 2024

folkertdev commented Apr 20, 2024

folkertdev commented Apr 22, 2024

Byron left a comment

folkertdev commented Apr 23, 2024 •

edited

Byron commented Apr 24, 2024 •

edited

joshtriplett Apr 24, 2024

folkertdev Apr 24, 2024

joshtriplett left a comment

folkertdev commented Apr 24, 2024

Byron commented Apr 25, 2024

Byron commented Apr 26, 2024

torokati44 commented Apr 28, 2024

Byron commented Apr 29, 2024

torokati44 commented Apr 29, 2024

add zlib-rs support via the libz-rs-sys C api for zlib-rs #400

add zlib-rs support via the libz-rs-sys C api for zlib-rs #400

Conversation

folkertdev commented Apr 16, 2024

folkertdev Apr 16, 2024

Choose a reason for hiding this comment

folkertdev Apr 16, 2024

Choose a reason for hiding this comment

folkertdev Apr 16, 2024

Choose a reason for hiding this comment

joshtriplett Apr 24, 2024

Choose a reason for hiding this comment

Byron left a comment

Choose a reason for hiding this comment

folkertdev commented Apr 17, 2024

Byron commented Apr 17, 2024

oyvindln commented Apr 17, 2024 • edited

Byron commented Apr 17, 2024

oyvindln commented Apr 18, 2024 • edited

Byron commented Apr 18, 2024

folkertdev commented Apr 20, 2024

oyvindln commented Apr 20, 2024

folkertdev commented Apr 20, 2024

folkertdev commented Apr 22, 2024

Byron left a comment

Choose a reason for hiding this comment

folkertdev commented Apr 23, 2024 • edited

Byron commented Apr 24, 2024 • edited

joshtriplett Apr 24, 2024

Choose a reason for hiding this comment

folkertdev Apr 24, 2024

Choose a reason for hiding this comment

joshtriplett left a comment

Choose a reason for hiding this comment

folkertdev commented Apr 24, 2024

Byron commented Apr 25, 2024

Byron commented Apr 26, 2024

torokati44 commented Apr 28, 2024

Byron commented Apr 29, 2024

torokati44 commented Apr 29, 2024

add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` #400

add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` #400

oyvindln commented Apr 17, 2024 •

edited

oyvindln commented Apr 18, 2024 •

edited

folkertdev commented Apr 23, 2024 •

edited

Byron commented Apr 24, 2024 •

edited