Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "New API token" page defaults to "no expiration" #6664

Open
fasterthanlime opened this issue Jun 23, 2023 · 4 comments
Open

The "New API token" page defaults to "no expiration" #6664

fasterthanlime opened this issue Jun 23, 2023 · 4 comments
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@fasterthanlime
Copy link

Current Behavior

The "New API token" page defaults to "no expiration"

image

Expected Behavior

I think it should default to, like, "90 days". Or even "365 days" if you want to be conservative.

Defaults matter here. If I'm going to be irresponsible with a never-expiring token, make me do two additional clicks.

Steps To Reproduce

  1. Go to https://crates.io/settings/tokens/new
  2. Notice it defaults to no expiration

Environment

  • Browser: Microsoft Edge, for the street cred
  • OS: Windows 11, to have sound

Anything else?

Thanks for your work on this! The new form is definitely a step in the right direction.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 23, 2023
@Turbo87
Copy link
Member

Turbo87 commented Jun 23, 2023

We've chosen this default for now since it matches the previous behavior. Once people are a bit more familiar we will most likely switch it over to one of the presets instead.

@zahash
Copy link

zahash commented Aug 29, 2023

can i work on this issue? i can change it to 30 days.

@Turbo87
Copy link
Member

Turbo87 commented Aug 29, 2023

we have not decided yet at what point we want to change the default value. until then it's probably not worth looking into :)

@Turbo87
Copy link
Member

Turbo87 commented Feb 19, 2024

we talked a bit about this issue in our team meeting last friday. the conclusion was that we would like to have an implementation of token expiry warning emails first before we switch the default expiry time. the reasoning behind this is the situation where a Rust newcomer creates a default token on crates.io to put it into cargo and then 30 days later is surprised that nothing works anymore. we feel like this situation can be mitigated to some degree by having such expiry emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

3 participants