Workspaced crate READMEs do not display relative images correctly

[redstrate]

Current Behavior

Viewing the README of a crate that is originally from a workspace (take imgui-rs as an example) the image is not found. This is specifically member crates that share a README from the parent folder, and relatively references images in that location.

Expected Behavior

The image should be loaded correctly.

Steps To Reproduce

1. Go to the imgui-rs crates.io page.

Environment

• Browser: Safari 16.0
• OS: macOS 12.6

Anything else?

I believe I know the crux of this issue. Take a look at this snippet I have:

At around line 206 in lib.rs:

new_url += if is_media { "raw/HEAD" } else { "blob/HEAD" };
if !self.base_dir.is_empty() {
    new_url += "/";
    new_url += &self.base_dir;
}

For reference, the URL generated currently is this:

https://github.com/imgui-rs/imgui-rs/raw/HEAD/../hello_world.png

Obviously, it's trying to append base_dir (which because this is a workspace crate, I'm assuming is ..) but GitHub clearly doesn't like that. Removing the .. and just writing:

https://github.com/imgui-rs/imgui-rs/raw/HEAD/hello_world.png

Does work! So I wonder if this routine should be modified, so we collapse .. if needed. See imgui's Cargo.toml for how this happened:

[package]
name = "imgui"
readme = "../README.markdown"

I can write up a quick PR to fix this myself, but I wanted to know if there's any kind of weird edge case this code was supposed to be handling.

[Turbo87]

hmm... looking at https://github.com/imgui-rs/imgui-rs/tree/main/imgui, the image also does not appear to render correctly because in the symlinked README the path is actually incorrect 😅

with readme = "../README.markdown" this should be irrelevant though and probably still work. the path resolution has decent test coverage iirc, so if you do find a way to fix this with a PR I'd be happy to take a look and hopefully merge it :)