Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footnote links aren’t made into hyperlinks #1301

Open
linkmauve opened this issue Apr 8, 2024 · 4 comments · May be fixed by #1303
Open

Footnote links aren’t made into hyperlinks #1301

linkmauve opened this issue Apr 8, 2024 · 4 comments · May be fixed by #1303

Comments

@linkmauve
Copy link

At https://blog.rust-lang.org/2024/03/30/i128-layout-update.html the links in the footnotes aren’t converted to hyperlinks, making them more cumbersome to follow.
@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2024

The links seem to work for me. For example, clicking the 3 here goes to the bottom of the page.
image

Can you say which browser and OS you are using? Are the links not underlined? Does clicking them not change the URL fragment to something like #fn-l?

@linkmauve
Copy link
Author

I’m using Firefox nightly on ArchLinux all up to date, and the links aren’t underlined in the footnote itself, not in the link to the footnote, see this screenshot:

@Mark-Simulacrum
Copy link
Member

They probably need to be surrounded in < > to make them a URL. Footnotes are just text and we don't auto-link in text I guess.

@ehuss ehuss linked a pull request Apr 8, 2024 that will close this issue
Open
@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2024

Oh, sorry, I misunderstood. Posted #1303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix footnote links in layout update post. ehuss/blog.rust-lang.org
3 participants
@ehuss @Mark-Simulacrum @linkmauve