Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itertools::dedup_by[_key] vs Vec #930

Open
Philippe-Cholet opened this issue May 4, 2024 · 0 comments
Open

Itertools::dedup_by[_key] vs Vec #930

Philippe-Cholet opened this issue May 4, 2024 · 0 comments

Comments

@Philippe-Cholet
Copy link
Member

First, Itertools::dedup_by[_with_count] uses FnMut(&Self::Item, &Self::Item) -> bool while Vec::dedup_by uses FnMut(&mut T, &mut T) -> bool. It differs in mutability: & vs &mut. Not sure why yet.

Second, Vec::dedup_by_key exists but Itertools::dedup_by_key[_with_count] do not:

trait Itertools {
    fn dedup_by_key<F, K>(self, key: F) -> DedupByKey<Self, F>
    where
        Self: Sized,
        F: FnMut(&/*mut ??*/ Self::Item) -> K,
        K: PartialEq;

    fn dedup_by_key_with_count<F, K>(self, key: F) -> DedupByKeyWithCount<Self, F>
    where
        Self: Sized,
        F: FnMut(&/*mut ??*/ Self::Item) -> K,
        K: PartialEq;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant