MapInto: relax Debug/Clone bounds
#889
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive those adds a bound on `U` which is not needed since it's only `PhantomData`. Note that `PhantomData<T>` is `Debug` for any `T`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 94.38% 94.55% +0.16%
==========================================
Files 48 48
Lines 6665 6753 +88
==========================================
+ Hits 6291 6385 +94
+ Misses 374 368 -6 ☔ View full report in Codecov by Sentry. |
phimuemue
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive those adds a bound on
Uwhich is not needed (I checked with the "expand macros" tool of the Rust playground) since it's onlyPhantomData.Note that
PhantomData<T>isDebug + Clonefor anyT.I can hit easily hit the error (playground).