Deprecate group_by in favor of chunk_by
#866
Merged
+122
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
==========================================
- Coverage 94.20% 94.09% -0.12%
==========================================
Files 48 48
Lines 6676 6684 +8
==========================================
Hits 6289 6289
- Misses 387 395 +8 ☔ View full report in Codecov by Sentry. |
Philippe-Cholet
force-pushed
the
rename-group_by-to-chunk_by
branch
from
edada59 to
0393dc5
Compare
Philippe-Cholet
force-pushed
the
rename-group_by-to-chunk_by
branch
from
0393dc5 to
14f5b62
Compare
phimuemue
approved these changes
Feb 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fixes #374 (see #374 (comment) and above for more details).
What do you think?
I'm not entirely sure of the documentation changes: when to use to term "chunk" and when to use "group".
I could additionally make "consecutive" bold.