Test double ended specializations #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `test_specializations` but for `DoubleEndedIterator::{rfold,nth_back}`.
The other difference is that in the macro, I advance the iterator alternatively from both fronts 8 times instead of one front 5 times.
Note that we don't have any `rfold/nth_back` specialization yet but it will come as I intend to do `rfold` specializations alongside `fold` ones.
I previously forgot `repeat_n`.
phimuemue
approved these changes
Dec 7, 2023
jswrenn
approved these changes
Dec 7, 2023
|
@phimuemue So opt-in or opt-out? I sure would prefer to merge those two functions in whatever form that detect if it needs to be done or not (I mean, checking if each of them should have a double ended test was not really quick to do), here and for benchmarks. But I don't see a way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any
rfold/nth_backspecialization yet but it will come as I intend to dorfoldspecializations alongsidefoldones (benchmarks are ready too).Apart from
rciterfor which I did not add any specialization test, all our double ended iterators are included here.