Make Product lazy
#800
Merged
Make Product lazy
#800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what is done by `core::iter::Peekable`, a nested option is now used.
`b` size hint was computed even when not needed.
11 tasks
jswrenn
approved these changes
Nov 13, 2023
Philippe-Cholet
force-pushed
the
product-laziness
branch
from
6b61676
to
3b18fd4
Compare
jswrenn
approved these changes
Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #792.
To make the
Productadaptor lazy, I use a nested option, just like I did in #797.Then the method
cartesian_productand the macroiproductwill be lazy.