Make Intersperse[With] lazy
#797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2023
Philippe-Cholet
force-pushed
the
intersperse-laziness
branch
from
89d7c61
to
8286788
Compare
jswrenn
requested changes
Nov 13, 2023
| @@ -54,18 +54,17 @@ where | |||
| { | |||
| element: ElemF, | |||
| iter: Fuse<I>, | |||
| peek: Option<I::Item>, | |||
| peek: Option<Option<I::Item>>, | |||
There was a problem hiding this comment.
With the added nesting, could you just write a comment here about how the value of peek should be interpreted? (None, Some(None), Some(Some(...))?
There was a problem hiding this comment.
Done. And I will do the same for Product and CoalesceBy before publishing their similar laziness fix.
Similar to what is done by `core::iter::Peekable`, a nested option is now used.
Philippe-Cholet
force-pushed
the
intersperse-laziness
branch
from
aa88619
to
0dd980b
Compare
jswrenn
approved these changes
Nov 13, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #792
To make
Intersperse[With]adaptors lazy, I use a nested option which is whatcore::iter::Peekableuses internally.EDITs: I certainly hope that it's okay to use a nested option in such case because I did a similar thing to make
Productlazy (fixingcartesian_productandiproduct!un-laziness) and makeCoalesceBylazy (fixing 5 methods) that I'll publish once this PR is merged.