use 'cargo-hack' to run MSRV check without dev dependencies #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
requested changes
Sep 19, 2023
|
latest bug looks like some kind of network error. |
danieleades
force-pushed
the
msrv-fix
branch
from
b806484
to
db81844
Compare
danieleades
commented
Sep 19, 2023
| msrv: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| CARGO_NET_GIT_FETCH_WITH_CLI: true |
There was a problem hiding this comment.
the 1.43.1 version of cargo does not appear to work in CI without this line. This should be reviewed on the next MSRV bump
Merged
jswrenn
requested changes
Sep 19, 2023
danieleades
force-pushed
the
msrv-fix
branch
from
87cde43
to
6e5dcbf
Compare
|
I don't know much about CI configuration yet so I can only approve the documentation change about MSRV. |
Philippe-Cholet
approved these changes
Sep 20, 2023
jswrenn
approved these changes
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decouple the MSRV check from the dev dependencies using
cargo-hackthis allows dev dependencies to be updated without impacting downstream users.
note that the MSRV used in this PR was found using the following command-
cargo msrv -- cargo no-dev-deps check(which requires installing
cargo-msrvandcargo-no-dev-deps)