Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the msrv configuration from 'clippy.toml' to 'Cargo.toml' #672

Merged
merged 1 commit into from Feb 20, 2023

Conversation

danieleades
Copy link
Contributor

what it says on the tin.

The MSRV can now be set in Cargo.toml rather than clippy.toml. Clippy parses the field from Cargo.toml.

This has the added advantage that if you try to compile this crate with a toolchain older than the MSRV you'll get a nicer error message. Or you would if the MSRV wasn't so old that it doesn't make use of the rust-version key...

still, it's the thought the counts. This change is future-proof, and is also backwards compatible, since unrecognised keys cause warnings, but not errors.

@phimuemue
Copy link
Member

phimuemue commented Jan 31, 2023

Hi there, thanks for this.

Prior to Rust 1.56, cargo emits a warning when encountering rust-version (see https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field), but that would be ok for me.

@jswrenn Would you be ok with that?

@jswrenn jswrenn added this to the next milestone Feb 20, 2023
@jswrenn
Copy link
Member

jswrenn commented Feb 20, 2023

That's fine by me.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

Build succeeded:

@bors bors bot merged commit 5c21a87 into rust-itertools:master Feb 20, 2023
@danieleades danieleades deleted the rust-version branch February 20, 2023 17:47
@jswrenn jswrenn modified the milestones: next, v11.0.0 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants