Minmax set (prev "Add {min,max}_set(_by{_key)?)? functions") #613
+346
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function min_set returns a Vec of all the minimum values. All variants for max and with key extraction and comparison functions are added also. Since the functions need to return an unknown number of values and the values are not known until the iterator is finished, the function needs to allocate memory. Therefore Vec is used for returning the values.
…alOrd We may relax this bound at some point, but I'd go with this until we have evidence that it bothers users, as there have been cases where I actually was happy to be informed about Ord vs PartialOrd.
We may relax this bound at some point, but I'd go with this until we have evidence that it bothers users, as there have been cases where I actually was happy to be informed about Ord vs PartialOrd.
… instead of bool More canonical.
Slightly simplifies control flow as it avoids mutable variables that may not even be used in case of early return.
the {min,max}_set results must contain the result of the corresponding
{min,max} variant.
|
This looks great to me and thanks for taking over and fixing it. |
jswrenn
approved these changes
May 23, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #323 (I did not know how I could amend to the original PR, so sorry for the "duplicate" PR here.)
The original PR by @zayenz looked rather good. I adjusted the stuff that came up during discussion back then:
Vecinstead ofOption- emptiness is sufficiently well represented byVec.Ordinstead ofPartialOrd- just asIterator::min.ltby accepting aFnMut(...)->Ordering- seems canonical compared to thebool-solution.for-loop.Moreover, I simplified some bits.